From: "Krzysztof Wilczyński" <kwilczynski@kernel.org>
To: Marek Vasut <marek.vasut+renesas@mailbox.org>
Cc: linux-pci@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Magnus Damm <magnus.damm@gmail.com>,
Manivannan Sadhasivam <mani@kernel.org>,
Rob Herring <robh@kernel.org>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v3] PCI: rcar-gen4: Add missing 1ms delay after PWR reset assertion
Date: Fri, 19 Sep 2025 23:13:40 +0900 [thread overview]
Message-ID: <20250919141340.GA709855@rocinante> (raw)
In-Reply-To: <20250919134644.208098-1-marek.vasut+renesas@mailbox.org>
Hello,
[...]
> Fixes: 0d0c551011df ("PCI: rcar-gen4: Add R-Car Gen4 PCIe controller support for host mode")
> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
Missed a tag from me. :) But we can add it when applying, no worries.
> - if (!reset_control_status(dw->core_rsts[DW_PCIE_PWR_RST].rstc))
> + if (!reset_control_status(dw->core_rsts[DW_PCIE_PWR_RST].rstc)) {
> reset_control_assert(dw->core_rsts[DW_PCIE_PWR_RST].rstc);
> + /*
> + * R-Car V4H Reference Manual R19UH0186EJ0130 Rev.1.30 Apr. 21, 2025 page 585
> + * Figure 9.3.2 Software Reset flow (B) indicates that for peripherals in HSC
> + * domain, after reset has been asserted by writing a matching reset bit into
> + * register SRCR, it is mandatory to wait 1ms.
> + */
> + fsleep(1000);
Thank you!
Krzysztof
next prev parent reply other threads:[~2025-09-19 14:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-19 13:45 [PATCH v3] PCI: rcar-gen4: Add missing 1ms delay after PWR reset assertion Marek Vasut
2025-09-19 14:13 ` Krzysztof Wilczyński [this message]
2025-09-19 14:21 ` Marek Vasut
2025-09-25 16:45 ` Manivannan Sadhasivam
2025-09-22 11:10 ` Geert Uytterhoeven
2025-09-25 16:36 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250919141340.GA709855@rocinante \
--to=kwilczynski@kernel.org \
--cc=bhelgaas@google.com \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mani@kernel.org \
--cc=marek.vasut+renesas@mailbox.org \
--cc=robh@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox