From: Bjorn Helgaas <helgaas@kernel.org>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: linux-pci@vger.kernel.org, "Bjorn Helgaas" <bhelgaas@google.com>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
linux-kernel@vger.kernel.org,
"Lucas De Marchi" <lucas.demarchi@intel.com>
Subject: Re: [PATCH 0/2] PCI: Fix bogus resource overlaps
Date: Wed, 24 Sep 2025 18:48:05 -0500 [thread overview]
Message-ID: <20250924234805.GA2142481@bhelgaas> (raw)
In-Reply-To: <20250924134228.1663-1-ilpo.jarvinen@linux.intel.com>
On Wed, Sep 24, 2025 at 04:42:26PM +0300, Ilpo Järvinen wrote:
> Hi all,
>
> I noticed a few bogus resource overlaps in logs which occurred for PNP
> resource addresses that collided with large zero-based resources
> (typically IOV resources). It turns out, the problem boils down to not
> marking resources properly with IORESOURCE_UNSET when BAR is read into
> the struct resource.
>
> I've long wanted to mark resource not within their window with
> IORESOURCE_UNSET as done in patch 2, however, my first attempt to do it
> failed because the bridge window resources were not yet available. I
> assumed the bridge window change would require more extensive changes
> and postponed it, but it turns there were no big complications from it
> (at least so far).
>
> But things may be more complicated than I know so if you think there's
> a good reason why the filling of bridge resources is delayed to the
> second read, please speak up!
>
> There are extra notes in both patches under --- line, please check
> them as well.
>
> This series does not removed the second read of the bridge resources,
> it's probably unnecessary work now but confirming that requires more
> testing and code reading than I currently have time for so just sending
> the obvious fix series out (and adding a TODO entry for myself for
> later).
>
> Ilpo Järvinen (2):
> PCI: Setup bridge resources earlier
> PCI: Resources outside their window must set IORESOURCE_UNSET
>
> drivers/pci/probe.c | 45 ++++++++++++++++++++++++++++++++++++++++++---
> 1 file changed, 42 insertions(+), 3 deletions(-)
Applied to pci/resource for v6.18, thanks!
prev parent reply other threads:[~2025-09-24 23:48 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-24 13:42 [PATCH 0/2] PCI: Fix bogus resource overlaps Ilpo Järvinen
2025-09-24 13:42 ` [PATCH 1/2] PCI: Setup bridge resources earlier Ilpo Järvinen
2025-10-06 8:00 ` Val Packett
2025-10-06 10:46 ` Ilpo Järvinen
2025-10-06 20:08 ` Val Packett
2025-10-07 15:43 ` Ilpo Järvinen
2025-10-09 7:29 ` Val Packett
2025-10-10 17:01 ` Ilpo Järvinen
2025-10-12 6:29 ` Val Packett
2025-10-16 7:42 ` Manivannan Sadhasivam
2025-10-13 21:01 ` Bjorn Helgaas
2025-10-28 22:47 ` Bjorn Helgaas
2025-10-30 22:08 ` Bjorn Helgaas
2025-10-13 18:07 ` Guenter Roeck
2025-10-14 11:20 ` Ilpo Järvinen
2025-10-17 18:22 ` Bhanu Seshu Kumar Valluri
2025-10-17 18:27 ` Bhanu Seshu Kumar Valluri
2025-10-17 18:52 ` Bjorn Helgaas
2025-10-18 1:57 ` Bhanu Seshu Kumar Valluri
2025-10-20 18:46 ` Ilpo Järvinen
2025-10-27 8:10 ` Bhanu Seshu Kumar Valluri
2025-10-27 13:49 ` Ilpo Järvinen
2025-09-24 13:42 ` [PATCH 2/2] PCI: Resources outside their window must set IORESOURCE_UNSET Ilpo Järvinen
2025-09-25 21:21 ` Bjorn Helgaas
2025-09-26 12:21 ` Ilpo Järvinen
2025-09-26 19:30 ` Bjorn Helgaas
2025-09-29 10:34 ` Ilpo Järvinen
2025-09-30 15:47 ` Geert Uytterhoeven
2025-09-30 16:32 ` Ilpo Järvinen
2025-10-01 11:49 ` Geert Uytterhoeven
2025-10-01 13:06 ` Ilpo Järvinen
2025-10-01 14:08 ` Geert Uytterhoeven
2025-10-02 14:54 ` Ilpo Järvinen
2025-10-02 15:25 ` Geert Uytterhoeven
2025-10-02 16:59 ` Ilpo Järvinen
2025-10-03 8:36 ` Geert Uytterhoeven
2025-10-03 14:58 ` Ilpo Järvinen
2025-10-06 10:14 ` Geert Uytterhoeven
2025-10-06 12:37 ` Ilpo Järvinen
2025-10-06 13:17 ` Geert Uytterhoeven
2025-10-07 17:30 ` Ilpo Järvinen
2025-10-08 8:40 ` Kai-Heng Feng
2025-10-08 13:57 ` Geert Uytterhoeven
2025-09-24 23:48 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250924234805.GA2142481@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox