From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f227.google.com (mail-pl1-f227.google.com [209.85.214.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 912FD221269 for ; Fri, 3 Oct 2025 19:56:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.227 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759521381; cv=none; b=HIJnaKleHItuyIa52IfffkavKZqItPl536NmlzDFlmeasLV5/0U5c/4tzBhMdWbYl1Q57hRlMMv0Kg2Q2h2nsI5Z1nTIYj8WwncqsgCxmrQoksHB+UkPkcq5e2MguxZD1gzWrHLoN58VEVr1JsoMAOx9VIznUEQBW8IMZJ6b/yE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759521381; c=relaxed/simple; bh=+uLXOevcin9GX8uM8pwPTi35EjkCinCKRxZQkv7MOrY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=PNzccErgsZbONYME1vaas7FjAjR+OdL4L6rJRyX8wRW8zpRAaDrmn72NnKPXR/Irb3y7yco2lLPjiSl5Wzg3I8LRhwKuFhWtxCUOCHySw7EXH9CA73WrmprdJHzqKIvQO1TZg4Da3r8wfwsUDf9LyUKY3VFN1FMa40s6uiCLP9s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=O2edgYvk; arc=none smtp.client-ip=209.85.214.227 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="O2edgYvk" Received: by mail-pl1-f227.google.com with SMTP id d9443c01a7336-27eec33b737so34492575ad.1 for ; Fri, 03 Oct 2025 12:56:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759521378; x=1760126178; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dbpDWJdZfVTVSB8z3KjE43n+mbMdK6iqWDy5+ydNGZc=; b=icM0cnwWn2eTEnH+Bl9YnbcugNx/S/p5lJRr/JqWcXC10mZ4y3lA1MxGiAzVwBrbeb 5kEx/c9I95U4SvDZdoMRVwHe+AjZ/QoB+f3V/woDNMrsFzk/2FR1tsUzocFFftF4R46J FZ7C1xvnZT94lXLRjqk7cGiDVcBHdpkO5LK6gXy96Jq//2pxBTlHOoF+BddoKi+3LlS6 NDt12vWA+/1ABZCKKJ9gpNw9cbupV8cwoE7Ai0KNYEuWwSXz/wp6q0rcxjfWHa8pkper 1GeZ71gkXBHr7lEPLoF3iZ8lXDTF/57wY1VLGM+9RYM3HJC80LMuoSU86XBD/aOYvQgi PUHQ== X-Gm-Message-State: AOJu0YyyR3U1r2hZYR+8v7Vud8m+YSyKBUbY8uTWruSTWWGNZXflMl10 rzXDH3icCSLNpL1D85v7zeNRqUniTUX7uvEa9c+ctNd1jI+MSDs7tgp/YyCy/dD37rnBK7a9ljk mNRqxbqVoSZt6aC70vc7goYmpUrutz0T3zFWWl1Wh7/miKqcPnP1Lt0e7F85JsbxGuR39xs1IkF E5MFr69pGziYP57RNAYSbXad7Bz4my1POsT9XHBGeUepkIc8RIAYDvn3J6a5MzJ/Lq3JouH4WfJ PJBD//3be20W5qE X-Gm-Gg: ASbGncsGGK58ws6DGNFlfvxMcC8i8ivTDTUm0vn9RDA7SufNmZzKdQJK/zUmnJGqqTv LLRsDFaoRf5hR8cGQGa3DbmoqH+9O4YfAzWBeYf1HD1IKZaPs2Jq8DCzloX+MRwOpRMGc66KMmG nb4OJuE8PWqVYuVJZ3E7rUo73+dR8qowqof0Qp3vdik8aCLwMcMfefheV5PHW2Kti3uY3ZEP0pT 4Cfy4Q0ydiw7j40PKjfY6v7yX5GnVUmbkJJ0SSPkXJMm6yph9PEWYiinCx78k+iGkRwUiBsrh/o rW7cA65LeikWaW78SY1H5Efgn2x75JEUsIp3CzV7FTtoot9cWpW3BGF+tdwg9z/ZyylOLODep3Q eStwJ+aUYJ6lu1y2USNSpyuEfqOUC0ZfhGlZVpvwcM5SxZXL4Derf9bE0BKUeRIwjoAsWfMXw8z ngjyjQJg== X-Google-Smtp-Source: AGHT+IHrMTf3IywcCXBfIi1sBnUj5qiBhl90XUPXjMAHsvljadOm8y8SWEobJt6Z8LfJEtycwKUI3B2bF3nR X-Received: by 2002:a17:903:3c63:b0:274:9dae:6a6d with SMTP id d9443c01a7336-28e9a62fe05mr49535995ad.34.1759521377936; Fri, 03 Oct 2025 12:56:17 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-13.dlp.protect.broadcom.com. [144.49.247.13]) by smtp-relay.gmail.com with ESMTPS id d9443c01a7336-28e8d19c89esm3840545ad.62.2025.10.03.12.56.17 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 03 Oct 2025 12:56:17 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-b59682541d5so4151820a12.0 for ; Fri, 03 Oct 2025 12:56:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1759521375; x=1760126175; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dbpDWJdZfVTVSB8z3KjE43n+mbMdK6iqWDy5+ydNGZc=; b=O2edgYvk5XjC5vNnRWKB8xdnOeqI3QG249AOH0UbUNQXRLt2e9ATCRW3T/6xnLs7Hk DlpqM3tNZLOAjautRPW3WtzJTZBanjpnqK+bbQ2oTLK96s3YqF07LRZ60pgaD1BaK57i 28a+Xp4OlxvntgmI7PcUePxbz7xJ2XCc5NduI= X-Received: by 2002:a05:6a20:2583:b0:2e5:c9ee:96fa with SMTP id adf61e73a8af0-32b6208e921mr6127495637.34.1759521375388; Fri, 03 Oct 2025 12:56:15 -0700 (PDT) X-Received: by 2002:a05:6a20:2583:b0:2e5:c9ee:96fa with SMTP id adf61e73a8af0-32b6208e921mr6127464637.34.1759521374911; Fri, 03 Oct 2025 12:56:14 -0700 (PDT) Received: from stband-bld-1.and.broadcom.net ([192.19.144.250]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b6099add13esm5371162a12.8.2025.10.03.12.56.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Oct 2025 12:56:14 -0700 (PDT) From: Jim Quinlan To: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com, james.quinlan@broadcom.com Cc: Florian Fainelli , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , linux-rpi-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v3 1/2] PCI: brcmstb: Add a way to indicate if PCIe bridge is active Date: Fri, 3 Oct 2025 15:56:06 -0400 Message-Id: <20251003195607.2009785-2-james.quinlan@broadcom.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251003195607.2009785-1-james.quinlan@broadcom.com> References: <20251003195607.2009785-1-james.quinlan@broadcom.com> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e In a future commit, a new handler will be introduced that in part does reads and writes to some of the PCIe registers. When this handler is invoked, it is paramount that it does not do these register accesses when the PCIe bridge is inactive, as this will cause CPU abort errors. To solve this we keep a spinlock that guards a variable which indicates whether the bridge is on or off. When the bridge is on, access of the PCIe HW registers may proceed. Since there are multiple ways to reset the bridge, we introduce a general function to obtain the spinlock, call the specific function that is used for the specific SoC, sets the bridge active indicator variable, and releases the spinlock. Signed-off-by: Jim Quinlan --- drivers/pci/controller/pcie-brcmstb.c | 40 +++++++++++++++++++++++---- 1 file changed, 35 insertions(+), 5 deletions(-) diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c index 9afbd02ded35..9f1f746091be 100644 --- a/drivers/pci/controller/pcie-brcmstb.c +++ b/drivers/pci/controller/pcie-brcmstb.c @@ -30,6 +30,7 @@ #include #include #include +#include #include #include @@ -259,6 +260,7 @@ struct pcie_cfg_data { int (*perst_set)(struct brcm_pcie *pcie, u32 val); int (*bridge_sw_init_set)(struct brcm_pcie *pcie, u32 val); int (*post_setup)(struct brcm_pcie *pcie); + bool has_err_report; }; struct subdev_regulators { @@ -303,6 +305,8 @@ struct brcm_pcie { struct subdev_regulators *sr; bool ep_wakeup_capable; const struct pcie_cfg_data *cfg; + bool bridge_in_reset; + spinlock_t bridge_lock; }; static inline bool is_bmips(const struct brcm_pcie *pcie) @@ -310,6 +314,24 @@ static inline bool is_bmips(const struct brcm_pcie *pcie) return pcie->cfg->soc_base == BCM7435 || pcie->cfg->soc_base == BCM7425; } +static int brcm_pcie_bridge_sw_init_set(struct brcm_pcie *pcie, u32 val) +{ + unsigned long flags; + int ret; + + if (pcie->cfg->has_err_report) + spin_lock_irqsave(&pcie->bridge_lock, flags); + + ret = pcie->cfg->bridge_sw_init_set(pcie, val); + /* If we fail, assume the bridge is in reset (off) */ + pcie->bridge_in_reset = ret ? true : val; + + if (pcie->cfg->has_err_report) + spin_unlock_irqrestore(&pcie->bridge_lock, flags); + + return ret; +} + /* * This is to convert the size of the inbound "BAR" region to the * non-linear values of PCIE_X_MISC_RC_BAR[123]_CONFIG_LO.SIZE @@ -1081,7 +1103,7 @@ static int brcm_pcie_setup(struct brcm_pcie *pcie) int memc, ret; /* Reset the bridge */ - ret = pcie->cfg->bridge_sw_init_set(pcie, 1); + ret = brcm_pcie_bridge_sw_init_set(pcie, 1); if (ret) return ret; @@ -1097,7 +1119,7 @@ static int brcm_pcie_setup(struct brcm_pcie *pcie) usleep_range(100, 200); /* Take the bridge out of reset */ - ret = pcie->cfg->bridge_sw_init_set(pcie, 0); + ret = brcm_pcie_bridge_sw_init_set(pcie, 0); if (ret) return ret; @@ -1565,7 +1587,7 @@ static int brcm_pcie_turn_off(struct brcm_pcie *pcie) if (!(pcie->cfg->quirks & CFG_QUIRK_AVOID_BRIDGE_SHUTDOWN)) /* Shutdown PCIe bridge */ - ret = pcie->cfg->bridge_sw_init_set(pcie, 1); + ret = brcm_pcie_bridge_sw_init_set(pcie, 1); return ret; } @@ -1653,7 +1675,9 @@ static int brcm_pcie_resume_noirq(struct device *dev) goto err_reset; /* Take bridge out of reset so we can access the SERDES reg */ - pcie->cfg->bridge_sw_init_set(pcie, 0); + ret = brcm_pcie_bridge_sw_init_set(pcie, 0); + if (ret) + goto err_reset; /* SERDES_IDDQ = 0 */ tmp = readl(base + HARD_DEBUG(pcie)); @@ -1921,7 +1945,10 @@ static int brcm_pcie_probe(struct platform_device *pdev) if (ret) return dev_err_probe(&pdev->dev, ret, "could not enable clock\n"); - pcie->cfg->bridge_sw_init_set(pcie, 0); + ret = brcm_pcie_bridge_sw_init_set(pcie, 0); + if (ret) + return dev_err_probe(&pdev->dev, ret, + "could not de-assert bridge reset\n"); if (pcie->swinit_reset) { ret = reset_control_assert(pcie->swinit_reset); @@ -1996,6 +2023,9 @@ static int brcm_pcie_probe(struct platform_device *pdev) return ret; } + if (pcie->cfg->has_err_report) + spin_lock_init(&pcie->bridge_lock); + return 0; fail: -- 2.34.1