From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB26E1990A7 for ; Mon, 13 Oct 2025 10:17:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760350667; cv=none; b=NvZiAuIeFZRjNQQtw0rx2MBZLgPBN+Kua0EgMcHBV4/qhsyO1gsrs5o+bfoOVsgpgbpOXPyNCmk4vL1YPvKc96uw+ZZqOFp8189Qy+LBoSohW0EBNhzEzyagbVt54Wdo5aEqWcz89OjkbbrkNNZVRIyLoZaWjGCK433j0Hy7Bpk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760350667; c=relaxed/simple; bh=fLqhCB9ZHaE35jEAvUwL/XlQACvFsJNj7NN+aAdIw+E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UOuh+tP2pmc8qm/v35n6jMWTX6JSbCEPFxxPUqdbTeQ3YFVX94FizyojALMPuDMo2Ds7vwk4otZ2/O8dcN6YqkF2t+qDPn+WW0Xr7+HHWsJlRjRCNOvVeog83NL84DpGnfszfWygNwl27ob9DSWzWucpgSgF5o5N2nBUBbchi9c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=e3qX2/5i; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="e3qX2/5i" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-339d7c403b6so3931074a91.2 for ; Mon, 13 Oct 2025 03:17:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760350665; x=1760955465; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rL8Zvity0qBrpOIGKiLq2gATcEJ0bdlrudF1QRk85so=; b=e3qX2/5iepCXH6WkrSyxJe7ORCQ8SRV46El9RZmkR9AV4HwElRyK5OFc4nLFWqN1tR gnoeHcNW+nIS8o9uiAV/SE1Q7wl3F/qE9E+mee3jeFpwZk0rH2a3+8OAaUiapa5W9yfd x2zFo6OEod/Fz/y2Q76TpjFZqPfhGw8ntS9SXeTAoD4jwQySMmTGK0eUUbI3pHLI6YVH EQeXTy9Rf2qdt4Uj/zPNtaD5CEJN7UK1yXFM+T2gdrMiUykhhDWw4eN+Sr6J51Ep4aAB DarIacU/aSAQE2TRaE39UJXVQ4L+HKfRfv5p7XX2mMicXKJ53h9IQOHM6kP2NtygFNKb X4xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760350665; x=1760955465; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rL8Zvity0qBrpOIGKiLq2gATcEJ0bdlrudF1QRk85so=; b=ZeRp4zBGCLMfkJTh8Rok7sDldwxTYYCm5IT9WPm6rXyccM7ArXKyYFhpER8kAIEGtR ZZn/62VW4NgZ9vX10RCZtqaHxo5F5tLAUl0lirYT2n7qsgOT1SgXzHYO/UJDWt33RvKq W1WnPxIGg/BnAJ6psFu7ucS9X4i+stOKdRMDa+e0svuBdjWXDhzUkX5NlOF+dVLv9vlq C8Ic5nmnTB2XqBeGYH9pUlPJPBpqfkbK8qIvXQY25Xn//yAEENSjqSu2r4XolJoRaSIt Fz4MYyoTLCeeE0AzR1xx//Pqtjyq7olLKq4qAlPRAk9zbOUvazbmK86zPQjYSzpzzAz7 fHZg== X-Forwarded-Encrypted: i=1; AJvYcCW46nA/3saJuEKytYOb5SI5L730uQ7Wd4TUVrKm4TQlfcosF9qQEKJqbk9LoqDW3ZBq/3HJX8ZEc+o=@vger.kernel.org X-Gm-Message-State: AOJu0YzeS+bt639WahZKygbizFnbXwr3ylkaeyTZk5k0hWcqR8SyyXu9 BMwHqgBcHveOc0e7YdA+6NBZFJc5m2ctzZHqL8mQzP8W7tVt1vsCRO1r X-Gm-Gg: ASbGnct3MsHhAqDw5/VpcHfKVrHPXqxB+MtffeTSwBl2OHDa8t9c+yBiR9R0jfnMTf7 U64ff9C98iy96RiYTvNvM0hy6jY1iMSXyjoADErPsK2sG9PfnDCzUSmVPeGXAwMlXxhJHg/JYnL iInZnjREgwvHdJbb14QeOFzXveRIszB47u90VKVS8TnqIidQJGs0upHZ602KbJOH9cku9MhuMXe gcDJhKF5rCvAdLXAgk9u/L1lyHpQMYVadK6uMNu7TfdcdMTo8cLGJDjNu6i83MvrBID873fzkCG Xvf33JM0lcG3b2CSpB/crO6YS5GTIvnYT2NPG2Rfwz9NuXArt6v3fBKeZqO7sRl+uVHrXniRT1t KZEHLXxN7t7bTbYB5FlVN8km0RnoOt5ZYFPkED6Ck+RhD8lzaIA== X-Google-Smtp-Source: AGHT+IHcngJ21CdNAU4iF9jGL+GrQ8wIh2V4zG56kXYLEpN2UR66JICC8m/eBuKADrldWfXWqWJEAw== X-Received: by 2002:a17:90b:3846:b0:339:a323:30fe with SMTP id 98e67ed59e1d1-33b51168e73mr29465661a91.14.1760350665091; Mon, 13 Oct 2025 03:17:45 -0700 (PDT) Received: from rockpi-5b ([45.112.0.108]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-33b52a5656dsm7422864a91.11.2025.10.13.03.17.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Oct 2025 03:17:44 -0700 (PDT) From: Anand Moon To: Vignesh Raghavendra , Siddharth Vadapalli , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , linux-omap@vger.kernel.org (open list:PCI DRIVER FOR TI DRA7XX/J721E), linux-pci@vger.kernel.org (open list:PCI DRIVER FOR TI DRA7XX/J721E), linux-arm-kernel@lists.infradead.org (moderated list:PCI DRIVER FOR TI DRA7XX/J721E), linux-kernel@vger.kernel.org (open list) Cc: Anand Moon Subject: [RFC v1 1/2] PCI: j721e: Use devm_clk_get_optional_enabled() to get the clock Date: Mon, 13 Oct 2025 15:47:23 +0530 Message-ID: <20251013101727.129260-2-linux.amoon@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251013101727.129260-1-linux.amoon@gmail.com> References: <20251013101727.129260-1-linux.amoon@gmail.com> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use devm_clk_get_optional_enabled() helper instead of calling devm_clk_get_optional() and then clk_prepare_enable(). It simplifies the error handling and makes the code more compact. This changes removes the unnecessary clk variable and assigns the result of the devm_clk_get_optional_enabled() call directly to pcie->refclk. This makes the code more concise and readable without changing the behavior. Cc: Siddharth Vadapalli Signed-off-by: Anand Moon --- drivers/pci/controller/cadence/pci-j721e.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/pci/controller/cadence/pci-j721e.c b/drivers/pci/controller/cadence/pci-j721e.c index 5bc5ab20aa6d..d6bbd04c615b 100644 --- a/drivers/pci/controller/cadence/pci-j721e.c +++ b/drivers/pci/controller/cadence/pci-j721e.c @@ -479,7 +479,6 @@ static int j721e_pcie_probe(struct platform_device *pdev) struct cdns_pcie_ep *ep = NULL; struct gpio_desc *gpiod; void __iomem *base; - struct clk *clk; u32 num_lanes; u32 mode; int ret; @@ -603,18 +602,11 @@ static int j721e_pcie_probe(struct platform_device *pdev) goto err_get_sync; } - clk = devm_clk_get_optional(dev, "pcie_refclk"); - if (IS_ERR(clk)) { - ret = dev_err_probe(dev, PTR_ERR(clk), "failed to get pcie_refclk\n"); - goto err_pcie_setup; - } - - ret = clk_prepare_enable(clk); - if (ret) { + pcie->refclk = devm_clk_get_optional_enabled(dev, "pcie_refclk"); + if (IS_ERR(pcie->refclk)) { dev_err_probe(dev, ret, "failed to enable pcie_refclk\n"); goto err_pcie_setup; } - pcie->refclk = clk; /* * Section 2.2 of the PCI Express Card Electromechanical -- 2.50.1