From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 565642FD1D7 for ; Mon, 13 Oct 2025 10:17:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760350675; cv=none; b=BVfL7tWVfpgsiMQ1yKxEKUUvQDDew4W8+eFxx7QDtheoj0dKNaeCJcEV1n5CDhdeZUVwKmBxZQdvck5vuu30Wx9p4KPOntZvyyAE2bLFy4oN+9QXZUdPbjVvbLUmTmdokRxvABVA7NEPVwSNrxkh5O8gpuSeemnHaaDGJoqO01M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760350675; c=relaxed/simple; bh=gNh1Q25ZNGRtB3EJ1DwzkXZengb0FpJ74GxfaGXFVu8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZBTbD08+NKDp+WhYXZkrxvhD0eehMPMiXk7EcSgYnORPv6Lew7dTE1z0k2KCFqgiZPDbFSxDvLZiQlLLWPrwBQzLD3d9EJs8hCQ5u317AQrLHdq2KIOB23/cOvFy6bjhuJ468dHzlhxS2/5835cfXM36mCwrouVXDslSBPig1X8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ajHd53Uu; arc=none smtp.client-ip=209.85.216.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ajHd53Uu" Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-32ed19ce5a3so3525399a91.0 for ; Mon, 13 Oct 2025 03:17:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760350671; x=1760955471; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=19kHdtY5ZhpAxDQMVT/2nG/beuKDqoa8OjmMddMbQbE=; b=ajHd53UudJG9M7Br4Ob6S4j01SwITX8ETUlwysJE9vrgDAva67AoEdTzmOOyypBe4Z 0500bfcaRTIOo5/VQ0h231a8WJZVJu1lrZOQ2uCEv07RQKH/fFkh2Se2ifBPDYGe42Qt GXDbCp4iJQbf9gePk2Lp9A/6/EljtPvW5iSBEvrSUwvl3t+AxujQ1Ox2TsS6LtkDqEeL uqAWH29HRRrB2sGVoQv0CLC10xr/4yq1UNa+7vEmu4oENc2q+NFKoaLFPt39FzIDx5ON T90TmL7kTXu4EuZ/Poy9LKfE2rXeK6XjC4O8THgAdcWaRKYIPpEzDX2iZ5H7F0ibIA4Z sWCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760350671; x=1760955471; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=19kHdtY5ZhpAxDQMVT/2nG/beuKDqoa8OjmMddMbQbE=; b=kKCUBIXVj7buTnyMiR8SzeTph6hBuFMgDG/WCtueWRsT/6YhFSNsKRoKtsDTUL1xW4 EQXwqe5320fp4w4iPm7dc+OgTwgnOTUlftuVj53VSv41Zw0QQnqp05Vn9fe4Hqp6LpDV zm3Twh3ZC+Jh5yPlEv3eDrqnyJdlrAFGqxNjuEj0etz3yRG4fXBbzHhqe4QiMPOg1880 5G92UnAbiqURVDgobfRMuikhMK8DiZWkZtX7KjDxbh3WyF/m/5aLE53hvWmFa3q0+Ix5 oldkBFXfEh6rX+5St8h7ampzCSGBNBdQUWrwN7btwwkvNwnEjTEqSlSNHs1sfr03Sgwt wkpA== X-Forwarded-Encrypted: i=1; AJvYcCXLhdONvzleXHWvi03H4L7ymMSHffEQP2F3Ojb8pGjH5flr4T0ygCsNjbPztGhe9YH7V9wu/C6pgFk=@vger.kernel.org X-Gm-Message-State: AOJu0YwdY19Ptpa3cCcpbouX8pMTI8Hxx/mVetSkUmuQ2YQMh1ZwBMCr QWIFWZUGCPUHykvavUowc2NhklL4/qwr5680iICqPvRNwU70L6UJfnmC X-Gm-Gg: ASbGncv1f4jKUHlqt8HpRSjVuvDYB2eHc48VXu3gukrlhO3+s2Xg2WrLY3sVW1jeqI9 ycO6nWLtlrIQsNMKCEQJg86y6GEnnvZLsMta2Qal04CNi33+RONwwviEsPwP9xabux6CfMLtz4k h4R5jiVCHYqmnPycGF8rb8DJ4aOdX17biNOQZzdvtbbPod2BXHNPr9NOKkHiTqkLn9sXAdtwG80 A8gbL5E3/SmR6tVs2jzyQGQP/nA3ZxqH1R5weRVy0Qj+VoWP01pFLpbhTR1DI3Jn49JI66mbE6I o/CGm8lPxRT8+k45fYIsvY0P1Oq+mFREYwAZeKqK0BFFrFPxsbzPPotAXIJYTIYEGSuze65hgL2 RBaS+40WqALK+YICT6ZLuDGdAgUB3hPo5RGLDWWQUxsoVZ1Z7og== X-Google-Smtp-Source: AGHT+IEyZirSf3fnKNnVB5Ye7lidBycAPJF9I2FEB25F5npassyZdVGtvN5Z0VaAFP1R3FsWO44BJg== X-Received: by 2002:a17:90b:4990:b0:338:3b73:39ce with SMTP id 98e67ed59e1d1-33b5138e3a7mr27708156a91.25.1760350671380; Mon, 13 Oct 2025 03:17:51 -0700 (PDT) Received: from rockpi-5b ([45.112.0.108]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-33b52a5656dsm7422864a91.11.2025.10.13.03.17.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Oct 2025 03:17:50 -0700 (PDT) From: Anand Moon To: Vignesh Raghavendra , Siddharth Vadapalli , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , linux-omap@vger.kernel.org (open list:PCI DRIVER FOR TI DRA7XX/J721E), linux-pci@vger.kernel.org (open list:PCI DRIVER FOR TI DRA7XX/J721E), linux-arm-kernel@lists.infradead.org (moderated list:PCI DRIVER FOR TI DRA7XX/J721E), linux-kernel@vger.kernel.org (open list) Cc: Anand Moon Subject: [RFC v1 2/2] PCI: j721e: Use inline reset GPIO assignment and drop local variable Date: Mon, 13 Oct 2025 15:47:24 +0530 Message-ID: <20251013101727.129260-3-linux.amoon@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251013101727.129260-1-linux.amoon@gmail.com> References: <20251013101727.129260-1-linux.amoon@gmail.com> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Change removes the unnecessary local gpiod variable and assigns the result of the devm_gpiod_get_optional() call directly to pcie->reset_gpio. This makes the code more concise and readable without changing the behavior. Cc: Siddharth Vadapalli Signed-off-by: Anand Moon --- drivers/pci/controller/cadence/pci-j721e.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/pci/controller/cadence/pci-j721e.c b/drivers/pci/controller/cadence/pci-j721e.c index d6bbd04c615b..1ece4b183dfa 100644 --- a/drivers/pci/controller/cadence/pci-j721e.c +++ b/drivers/pci/controller/cadence/pci-j721e.c @@ -477,7 +477,6 @@ static int j721e_pcie_probe(struct platform_device *pdev) struct j721e_pcie *pcie; struct cdns_pcie_rc *rc = NULL; struct cdns_pcie_ep *ep = NULL; - struct gpio_desc *gpiod; void __iomem *base; u32 num_lanes; u32 mode; @@ -589,12 +588,12 @@ static int j721e_pcie_probe(struct platform_device *pdev) switch (mode) { case PCI_MODE_RC: - gpiod = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW); - if (IS_ERR(gpiod)) { - ret = dev_err_probe(dev, PTR_ERR(gpiod), "Failed to get reset GPIO\n"); + pcie->reset_gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW); + if (IS_ERR(pcie->reset_gpio)) { + ret = dev_err_probe(dev, PTR_ERR(pcie->reset_gpio), + "Failed to get reset GPIO\n"); goto err_get_sync; } - pcie->reset_gpio = gpiod; ret = cdns_pcie_init_phy(dev, cdns_pcie); if (ret) { @@ -615,9 +614,9 @@ static int j721e_pcie_probe(struct platform_device *pdev) * This shall ensure that the power and the reference clock * are stable. */ - if (gpiod) { + if (pcie->reset_gpio) { msleep(PCIE_T_PVPERL_MS); - gpiod_set_value_cansleep(gpiod, 1); + gpiod_set_value_cansleep(pcie->reset_gpio, 1); } ret = cdns_pcie_host_setup(rc); -- 2.50.1