From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7AB2B1F239B for ; Tue, 14 Oct 2025 11:32:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760441578; cv=none; b=r4w6lomG0XFmAttptMFB2YmM5ri8H0hQGnCsZ8CDNU4loRXFXz4QZ3Q7rTJ5QGz+wbHQMe/qe1peR51XrrBZQy3SRHxvIi1LYcama0Pf/Li0bG6eO/951Kl2MtO45u1uTOkz8QgRiEojuS3bNACY/yKqVWlNA/f2cm/SI0xsePY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760441578; c=relaxed/simple; bh=PoKOs9TgSjfkqiMX2+2Ly0Vb1OFpd3epTvsXddSqn5Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ojaLN1aN0hLo/yPuKVsv3BLgKS3lK43WsMz2iJfVFtzBUQUmLS/uE2Wt/tOM6KGYhkkgRUx6ptJ6j/D2zqA+kwTWuTFYk2iXzuAyGG+c/99kA+slIKbtHopsCbyZ1Z3yJiv7F+M+gIjJyfGuSWqkZjeFATIvsCToPJerj5n0cBk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ccpaD//s; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ccpaD//s" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-79ef9d1805fso482467b3a.1 for ; Tue, 14 Oct 2025 04:32:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760441576; x=1761046376; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=E7UerwX9ObkYiq6vERvNVgcsL6sbi2km2IZoP2hNgnA=; b=ccpaD//spzzaSxtfpn3a98ddUjjV4cDzVLsd6W4R+fWzJVH62b33RPfUti9wtAaMQ7 qbe560HBwhjH4dJLIZmhmErnseh4HF1OtaoPuw//OFfhUD+ciFhLPIHrny/6qhTYKEv9 LVvJcqFHWqG37vPIBWYgtU6awZE3g4whDYHnswG5xbI0XOo/NVDxp36m3APC2nq6ElOy eAkCG/m2qDjNckqrJ3A3M2KpcSf8FNMySAe8gNopyGWEzqhEq2srdvy6aYUgREiFEBkU XStKv/DCCCTnJUEO90DJH+znobht6GOC6v9MXKsVK3/fQxl7OS/OEpB14gLC+ld0XPnW i2uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760441576; x=1761046376; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E7UerwX9ObkYiq6vERvNVgcsL6sbi2km2IZoP2hNgnA=; b=FsIGS483HECI9imTXc+008wdPSuTskKkMeP7pnP8m+11F98BL6sI4opdoXA/VGrWCY 9HL7qT2tzmyXmzFKGE+YAHlfeULsiTc/RQTCSmi4zt2RLW4p0I4X0yadYPdbnt2ckm5A q+RZ18Akw08qCUTso7K72VoYWPtDz39I9SVSWY+GwvYu+UhVMRSb9D0z1ebdiVtLy+4U 4b7g7TicAX5uuyA/Cvlo0BNU70hlzBDDfOzqp8yw+kOhC+5TiCujYbJPP55WrYgPrzpW tce/Is4XrzNwIJdpCX98AGSD1nPMWhr1i1HFGE+9uQw3cL1+monl1jlDNmcGM1eGr/CY wEig== X-Forwarded-Encrypted: i=1; AJvYcCXbRL5fXvwor36a0dUvAFDPQwcwJoTn1vNRrpdEe4suuEEY+sCQ82NB0aWGioxBqwVTqIa05xH8qjA=@vger.kernel.org X-Gm-Message-State: AOJu0YzeGimFMQbbLw7YkkW9vKWoMxXKFkjIO2pC4d1O3lGkisu7fDJI Q9jm1RrsQNgSW+9rOYPIO9k2kbXz1NgtWDJrOGeimOxmdn/hkKeXFuOM X-Gm-Gg: ASbGncvHwMdzLXR1lf20ok752lzYzzGD0WRxGogGj97hLPNVnilJ4WdWlwjDYVsoi8H UkGq4UoMFDGJVg1rJiYRjk3+W88uuHIuV9QRAn8zzdiHYaBGdIpMSAl0ZqdPKcdbOJ6bb8Z9F+/ JOy4i3Q3ywopdUuxUxuLJSSwvcr5vDxhFn0WCregXKyxNivQ89gi9RO8c7Eg8sDGpH//F5CcWWV nC72PJH1d95Gm9B3bsZ1Q/IYF1TMFS/AejRjOaYYBtOmiAYSCpO7hA+muA4os4FK7rXaDsWkneA +E/3l5mHoxosSGFPfSdSU917jGZH1MVSXfSZtL89ShENDE2Kyi+G76gbNxV4l6dczh66CMhUpBB GQeF5c73dsdv5j7haQEGGzU2MPqdd/XiQi7Yhv3KASPJIawzsuA== X-Google-Smtp-Source: AGHT+IFL/A1wjKWekovh/oihjR4JIjfCM839DB7WtztyHa+NpAIMVWIzCgumtsxtL4h7BgUTWYN4Fw== X-Received: by 2002:a05:6a00:182a:b0:781:275a:29d9 with SMTP id d2e1a72fcca58-7938742c7aemr32083308b3a.18.1760441575343; Tue, 14 Oct 2025 04:32:55 -0700 (PDT) Received: from rockpi-5b ([45.112.0.108]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7992d0965c3sm14871383b3a.52.2025.10.14.04.32.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Oct 2025 04:32:54 -0700 (PDT) From: Anand Moon To: Vignesh Raghavendra , Siddharth Vadapalli , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , linux-omap@vger.kernel.org (open list:PCI DRIVER FOR TI DRA7XX/J721E), linux-pci@vger.kernel.org (open list:PCI DRIVER FOR TI DRA7XX/J721E), linux-arm-kernel@lists.infradead.org (moderated list:PCI DRIVER FOR TI DRA7XX/J721E), linux-kernel@vger.kernel.org (open list) Cc: Anand Moon Subject: [PATCH v1 2/3] PCI: j721e: Use devm_clk_get_optional_enabled() to get the clock Date: Tue, 14 Oct 2025 17:02:28 +0530 Message-ID: <20251014113234.44418-3-linux.amoon@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251014113234.44418-1-linux.amoon@gmail.com> References: <20251014113234.44418-1-linux.amoon@gmail.com> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Use devm_clk_get_optional_enabled() helper instead of calling devm_clk_get_optional() and then clk_prepare_enable(). It simplifies the error handling and makes the code more compact. This changes removes the unnecessary clk variable and assigns the result of the devm_clk_get_optional_enabled() call directly to pcie->refclk. This makes the code more concise and readable without changing the behavior. Cc: Siddharth Vadapalli Signed-off-by: Anand Moon --- v1: Drop explicit clk_disable_unprepare — handled by devm_clk_get_optional_enabled Since devm_clk_get_optional_enabled internally manages clk_prepare_enable and clk_disable_unprepare as part of its lifecycle, the explicit call to clk_disable_unprepare is redundant and can be safely removed. --- drivers/pci/controller/cadence/pci-j721e.c | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/pci/controller/cadence/pci-j721e.c b/drivers/pci/controller/cadence/pci-j721e.c index 9c7bfa77a66e..ed8e182f0772 100644 --- a/drivers/pci/controller/cadence/pci-j721e.c +++ b/drivers/pci/controller/cadence/pci-j721e.c @@ -479,7 +479,6 @@ static int j721e_pcie_probe(struct platform_device *pdev) struct cdns_pcie_ep *ep = NULL; struct gpio_desc *gpiod; void __iomem *base; - struct clk *clk; u32 num_lanes; u32 mode; int ret; @@ -603,18 +602,11 @@ static int j721e_pcie_probe(struct platform_device *pdev) goto err_get_sync; } - clk = devm_clk_get_optional(dev, "pcie_refclk"); - if (IS_ERR(clk)) { - ret = dev_err_probe(dev, PTR_ERR(clk), "failed to get pcie_refclk\n"); - goto err_pcie_setup; - } - - ret = clk_prepare_enable(clk); - if (ret) { + pcie->refclk = devm_clk_get_optional_enabled(dev, "pcie_refclk"); + if (IS_ERR(pcie->refclk)) { ret = dev_err_probe(dev, ret, "failed to enable pcie_refclk\n"); goto err_pcie_setup; } - pcie->refclk = clk; /* * Section 2.2 of the PCI Express Card Electromechanical @@ -630,7 +622,6 @@ static int j721e_pcie_probe(struct platform_device *pdev) ret = cdns_pcie_host_setup(rc); if (ret < 0) { - clk_disable_unprepare(pcie->refclk); goto err_pcie_setup; } @@ -679,7 +670,6 @@ static void j721e_pcie_remove(struct platform_device *pdev) gpiod_set_value_cansleep(pcie->reset_gpio, 0); - clk_disable_unprepare(pcie->refclk); cdns_pcie_disable_phy(cdns_pcie); j721e_pcie_disable_link_irq(pcie); pm_runtime_put(dev); -- 2.50.1