Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Vincent Liu <vincent.liu@nutanix.com>
Cc: dakr@kernel.org, linux-kernel@vger.kernel.org, rafael@kernel.org,
	bhelgaas@google.com, linux-pci@vger.kernel.org
Subject: Re: [PATCH v2] driver core: Check drivers_autoprobe for all added devices
Date: Tue, 14 Oct 2025 07:14:27 +0200	[thread overview]
Message-ID: <2025101452-legacy-gizzard-5bd0@gregkh> (raw)
In-Reply-To: <20251013181459.517736-1-vincent.liu@nutanix.com>

On Mon, Oct 13, 2025 at 07:14:59PM +0100, Vincent Liu wrote:
> When a device is hot-plugged, the drivers_autoprobe sysfs attribute is
> not checked. This means that drivers_autoprobe is not working as
> intended, e.g. hot-plugged PCIe devices will still be autoprobed and
> bound to drivers even with drivers_autoprobe disabled.
> 
> Make sure all devices check drivers_autoprobe by pushing the
> drivers_autoprobe check into device_initial_probe. This will only
> affect devices on the PCI bus for now as device_initial_probe is only
> called by pci_bus_add_device and bus_probe_device (but bus_probe_device
> already checks for autoprobe). In particular for the PCI devices, only
> hot-plugged PCIe devices/VFs should be affected as the default value of
> pci/drivers_autoprobe remains 1 and can only be cleared from userland.
> 
> Any future callers of device_initial_probe will respsect the
> drivers_autoprobe sysfs attribute, but this should be the intended
> purpose of drivers_autoprobe.
> 
> Signed-off-by: Vincent Liu <vincent.liu@nutanix.com>
> ---
> v1->v2: Change commit subject to include driver core (no code change)
> 	https://lore.kernel.org/20251001151508.1684592-1-vincent.liu@nutanix.com

What commit id does this fix?  What devices cause this to happen today
that are seeing this issue?  Should this be backported to older kernels?

thanks,

greg k-h

  reply	other threads:[~2025-10-14  5:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20251001151508.1684592-1-vincent.liu@nutanix.com>
     [not found] ` <2025100209-hefty-catalyst-e5b2@gregkh>
2025-10-02 12:04   ` [PATCH] driver core: PCI: Check drivers_autoprobe for all added devices Vincent Liu
2025-10-13 18:14 ` [PATCH v2] driver core: " Vincent Liu
2025-10-14  5:14   ` Greg KH [this message]
2025-10-14 12:10     ` Vincent Liu
2025-10-21 12:49       ` Vincent Liu
2025-10-22 10:32         ` Greg KH
2025-10-14 20:07   ` Bjorn Helgaas
2025-10-15 10:23     ` Vincent Liu
2025-10-15 16:53       ` Bjorn Helgaas
2025-10-22 12:07 ` [PATCH v3] " Vincent Liu
2025-11-04 13:16   ` Vincent Liu
2025-11-20 17:00 ` [PATCH v3 RESEND] " Vincent Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025101452-legacy-gizzard-5bd0@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=bhelgaas@google.com \
    --cc=dakr@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=vincent.liu@nutanix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox