From: Lorenzo Pieralisi <lpieralisi@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org,
devicetree@vger.kernel.org, "Frank Li" <Frank.Li@nxp.com>,
"Rob Herring" <robh@kernel.org>,
"Sascha Bischoff" <sascha.bischoff@arm.com>,
"Scott Branden" <sbranden@broadcom.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Ray Jui" <rjui@broadcom.com>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Marc Zyngier" <maz@kernel.org>
Subject: [PATCH v3 2/5] of/irq: Fix OF node refcount in of_msi_get_domain()
Date: Fri, 17 Oct 2025 10:47:49 +0200 [thread overview]
Message-ID: <20251017084752.1590264-3-lpieralisi@kernel.org> (raw)
In-Reply-To: <20251017084752.1590264-1-lpieralisi@kernel.org>
In of_msi_get_domain() if the iterator loop stops early because an
irq_domain match is detected, an of_node_put() on the iterator node is
needed to keep the OF node refcount in sync.
Add it.
Signed-off-by: Lorenzo Pieralisi <lpieralisi@kernel.org>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Cc: Rob Herring <robh@kernel.org>
---
drivers/of/irq.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/of/irq.c b/drivers/of/irq.c
index e67b2041e73b..9f6cd5abba76 100644
--- a/drivers/of/irq.c
+++ b/drivers/of/irq.c
@@ -773,8 +773,10 @@ struct irq_domain *of_msi_get_domain(struct device *dev,
of_for_each_phandle(&it, err, np, "msi-parent", "#msi-cells", 0) {
d = irq_find_matching_host(it.node, token);
- if (d)
+ if (d) {
+ of_node_put(it.node);
return d;
+ }
}
return NULL;
--
2.50.1
next prev parent reply other threads:[~2025-10-17 8:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-17 8:47 [PATCH v3 0/5] of/irq: Misc msi-parent handling fixes/clean-ups Lorenzo Pieralisi
2025-10-17 8:47 ` [PATCH v3 1/5] of/irq: Add msi-parent check to of_msi_xlate() Lorenzo Pieralisi
2025-10-21 11:55 ` Rob Herring
2025-10-21 12:51 ` Lorenzo Pieralisi
2025-10-17 8:47 ` Lorenzo Pieralisi [this message]
2025-10-17 8:47 ` [PATCH v3 3/5] of/irq: Export of_msi_xlate() for module usage Lorenzo Pieralisi
2025-10-17 8:47 ` [PATCH v3 4/5] PCI: iproc: Implement MSI controller node detection with of_msi_xlate() Lorenzo Pieralisi
2025-10-17 8:47 ` [PATCH v3 5/5] irqchip/gic-its: Rework platform MSI deviceID detection Lorenzo Pieralisi
2025-10-17 20:24 ` [PATCH v3 0/5] of/irq: Misc msi-parent handling fixes/clean-ups Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251017084752.1590264-3-lpieralisi@kernel.org \
--to=lpieralisi@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mani@kernel.org \
--cc=maz@kernel.org \
--cc=rjui@broadcom.com \
--cc=robh@kernel.org \
--cc=sascha.bischoff@arm.com \
--cc=sbranden@broadcom.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox