From: Andrea della Porta <andrea.porta@suse.com>
To: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
mbrugger@suse.com, guillaume.gardet@arm.com, tiwai@suse.com
Cc: Andrea della Porta <andrea.porta@suse.com>
Subject: [PATCH] PCI: of: Downgrade error message on missing of_root node
Date: Tue, 21 Oct 2025 17:32:19 +0200 [thread overview]
Message-ID: <20251021153219.9665-1-andrea.porta@suse.com> (raw)
When CONFIG_PCI_DYNAMIC_OF_NODES is enabled, an error message
is generated if no 'of_root' node is defined.
On DT-based systems, this cannot happen as a root DT node is
always present. On ACPI-based systems, this is not a true error
because a DT is not used.
Downgrade the pr_err() to pr_info().
Signed-off-by: Andrea della Porta <andrea.porta@suse.com>
---
drivers/pci/of.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/of.c b/drivers/pci/of.c
index 3579265f1198..034486593210 100644
--- a/drivers/pci/of.c
+++ b/drivers/pci/of.c
@@ -775,7 +775,7 @@ void of_pci_make_host_bridge_node(struct pci_host_bridge *bridge)
/* Check if there is a DT root node to attach the created node */
if (!of_root) {
- pr_err("of_root node is NULL, cannot create PCI host bridge node\n");
+ pr_info("of_root node is NULL, cannot create PCI host bridge node\n");
return;
}
--
2.35.3
next reply other threads:[~2025-10-21 15:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-21 15:32 Andrea della Porta [this message]
2025-10-21 15:43 ` [PATCH] PCI: of: Downgrade error message on missing of_root node Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251021153219.9665-1-andrea.porta@suse.com \
--to=andrea.porta@suse.com \
--cc=bhelgaas@google.com \
--cc=guillaume.gardet@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mbrugger@suse.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox