From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33B052E6CB4 for ; Sat, 25 Oct 2025 07:43:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761378241; cv=none; b=pUHEL2nZIdJgDdarmKLS0gSSfa2LXEh5z3QNoZWlaXpauADqzefoQd9fxoeVIFd6X12r5MmyNpNibDLGCN8CJnkKAfQVek2p1M5/g/pVTqB8Pb0IM6OFLAyH+KP30BUDuI6Iw/j/MfxGrvDq3Bd4DzP0QjRXGQVg+tueOVZZvpU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761378241; c=relaxed/simple; bh=m/7BPONg68GpSItsiRmhbTDWbchfGgM+P5xwH8qJZCU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Q+B0wqpOJjN2BCTdX6HEPfj/wGgcXtrMTm2GrpSGSwsM2jhy0KhPmgNrjezwfwiM9Y04mmtGFxfnrxEAtspqeWj4uzMFgyOUY1Jtxmg5c48s8BC+m+J4TrUn0IkQRIYuTtzSXJAm61joP7CzP6KZ20BabPzpcwYaKHyFZY+xf9s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=G8WUl0bw; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="G8WUl0bw" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-781010ff051so1848807b3a.0 for ; Sat, 25 Oct 2025 00:43:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761378239; x=1761983039; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yAWi08Lab8Pg0FL7IYkK8ydZGRVaUiT7SC194s0JYPE=; b=G8WUl0bweiBaj+0V7YRznPlhSg894PknHJWVabF96EwMPVkqNeBdduYijeN/b5inIp rEtn2R8oykoCgzKs1p7b/v6cDpHhcZP65DWNOQwaxyN8wUh2z0r3f6uSRtfe3qnZpVAb IRAa0gZKhqUADh7vy/Xh1T1gOb95TkCNHqM+tNj4/76adUzK+d7o70e4WcygVpL5j+YL 976nOJZrQB6eyPiD+SGw+OlpCVWftyZJa9QBNCojEONZKB3yhPRwnl/z7r/OIvrhxHV8 ts2Cam/1bpQ2S2R8QEWE7UAEdSzbui2vDoKjT2VFFSzKSjOD8i+s+sbenbTmvVWfZELQ axgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761378239; x=1761983039; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yAWi08Lab8Pg0FL7IYkK8ydZGRVaUiT7SC194s0JYPE=; b=PX++TLOtMm9zugRRRgV9TNJf1EygpRdkHbO7cAMlgeYW0XeJGCmcke90vQAamsaGk4 mkUCZ0eDu32usTIyJyHXvxfXeFGLJ+cyVooq34oZWiM6FepRkDl4NtwZiGPmh/E4gW0M JAB3b0zL2lSkw7VOPN0R0zRicLCDpXhxBigsXsnJWRTYtKRuPuxCMBYFSHpxW/by15dG MHb5vHLOff3gW/Nu8drjtHWHxDqZKF/xhA2aSMU6FusJ6G1HX3xK9KCJXdQC4fFGZ4ow d9K3RR45cgC3laQGbZXqn76sKm6lpgr1P9OTBhbuCuIGr9MCoxF1MDhe+IIwUZ+EEd0r tWXg== X-Forwarded-Encrypted: i=1; AJvYcCVKWhFw4AjNcAVNoMIEv8bsZTq2Os3Rmt7BZQSoRo5T1vNKmupCL4N6nHnT3Z+ZJZzR+oE8npL3V48=@vger.kernel.org X-Gm-Message-State: AOJu0YxXHFYI3PWfqi4LMwJFde5yW8c5vXcFH1rimT9EnCXd2YLRjc2j PJy+2OVtqJCatLRqs0fD8NzLGBPvbDYV5UULDXX8RM6uKQoSmJY64nCl X-Gm-Gg: ASbGncvvblngGnxmDjV9mU7JpKdGdeb5H4TGpBmIdxTw5gF4Tgv2siS9PAMQD9BbhoZ WUdPh0kiefOi5YeI+dGabhQKSES4pM6qhhCMeI5fTDicf1BfPpZvGR5nUaYbwo9QhYYMpgOF9GD wj35HZ4sCCx4uCbub8LEBb0Dq24wzsOCH7RBcAFzYBwXs1YsxDhLtvYNI8c4TtXrqFEW3XydpJx UInd/sB7/s6tAE/PzfPeEkUETwPcz8aoHb1U+c9B9iBaaEuOC5oEVbZfYdabiINwkMPb7POuZoV Cerz0keFQgHxAiEHexQviE6fxt7UPwSESKH83gVifUmXhA5xhkw4Rv3LlwzG5Kdr5gUEFxI9d2i FeBSFBbLchSajmLZX40qYEITEIn+677VEnv76M2laTn49N9e8TrI/4Jia2GjCXHsYs3TD8VR3uV 3TFb07okeXYkvfeC4+V8w= X-Google-Smtp-Source: AGHT+IGHRGT9hB86/YyYWO+q0YYgQ20bBMxTaREfTvNN83eWQaMSQ0mxbxIpiJAX3TL83FC5ARBuiA== X-Received: by 2002:a05:6a20:1590:b0:334:b732:6e5c with SMTP id adf61e73a8af0-33c600a5574mr9633829637.13.1761378239355; Sat, 25 Oct 2025 00:43:59 -0700 (PDT) Received: from rockpi-5b ([45.112.0.108]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7a41404d760sm1395083b3a.39.2025.10.25.00.43.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Oct 2025 00:43:58 -0700 (PDT) From: Anand Moon To: Vignesh Raghavendra , Siddharth Vadapalli , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , linux-omap@vger.kernel.org (open list:PCI DRIVER FOR TI DRA7XX/J721E), linux-pci@vger.kernel.org (open list:PCI DRIVER FOR TI DRA7XX/J721E), linux-arm-kernel@lists.infradead.org (moderated list:PCI DRIVER FOR TI DRA7XX/J721E), linux-kernel@vger.kernel.org (open list) Cc: Anand Moon , Markus Elfring , Dan Carpenter Subject: [PATCH v2 2/2] PCI: j721e: Use inline reset GPIO assignment and drop local variable Date: Sat, 25 Oct 2025 13:13:32 +0530 Message-ID: <20251025074336.26743-3-linux.amoon@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251025074336.26743-1-linux.amoon@gmail.com> References: <20251025074336.26743-1-linux.amoon@gmail.com> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The result of devm_gpiod_get_optional() is now assigned directly assigned to pcie->reset_gpio. This removes a superfluous local gpiod variable, improving code readability and compactness. The functionality remains unchanged, but the code is now more streamlined Cc: Siddharth Vadapalli Reviewed-by: Siddharth Vadapalli Signed-off-by: Anand Moon --- v2: fix the commit message. v1: Add Rb - Siddharth --- drivers/pci/controller/cadence/pci-j721e.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/pci/controller/cadence/pci-j721e.c b/drivers/pci/controller/cadence/pci-j721e.c index b678f7d48206..633fe8f93102 100644 --- a/drivers/pci/controller/cadence/pci-j721e.c +++ b/drivers/pci/controller/cadence/pci-j721e.c @@ -477,7 +477,6 @@ static int j721e_pcie_probe(struct platform_device *pdev) struct j721e_pcie *pcie; struct cdns_pcie_rc *rc = NULL; struct cdns_pcie_ep *ep = NULL; - struct gpio_desc *gpiod; void __iomem *base; u32 num_lanes; u32 mode; @@ -589,12 +588,12 @@ static int j721e_pcie_probe(struct platform_device *pdev) switch (mode) { case PCI_MODE_RC: - gpiod = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW); - if (IS_ERR(gpiod)) { - ret = dev_err_probe(dev, PTR_ERR(gpiod), "Failed to get reset GPIO\n"); + pcie->reset_gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW); + if (IS_ERR(pcie->reset_gpio)) { + ret = dev_err_probe(dev, PTR_ERR(pcie->reset_gpio), + "Failed to get reset GPIO\n"); goto err_get_sync; } - pcie->reset_gpio = gpiod; ret = cdns_pcie_init_phy(dev, cdns_pcie); if (ret) { @@ -616,9 +615,9 @@ static int j721e_pcie_probe(struct platform_device *pdev) * This shall ensure that the power and the reference clock * are stable. */ - if (gpiod) { + if (pcie->reset_gpio) { msleep(PCIE_T_PVPERL_MS); - gpiod_set_value_cansleep(gpiod, 1); + gpiod_set_value_cansleep(pcie->reset_gpio, 1); } ret = cdns_pcie_host_setup(rc); -- 2.50.1