From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Lukas Wunner <lukas@wunner.de>
Cc: Crystal Wood <crwood@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Clark Williams <clrkwllms@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>,
linux-kernel@vger.kernel.org,
Attila Fazekas <afazekas@redhat.com>,
linux-pci@vger.kernel.org, linux-rt-devel@lists.linux.dev,
Bjorn Helgaas <helgaas@kernel.org>,
Mahesh J Salgaonkar <mahesh@linux.ibm.com>,
Oliver OHalloran <oohall@gmail.com>
Subject: Re: [PATCH] genirq/manage: Reduce priority of forced secondary IRQ handler
Date: Mon, 27 Oct 2025 09:18:06 +0100 [thread overview]
Message-ID: <20251027081806.qoogsX3l@linutronix.de> (raw)
In-Reply-To: <aP8T7rahGYzJqnP5@wunner.de>
On 2025-10-27 07:40:46 [+0100], Lukas Wunner wrote:
> > I suspect it was a non-issue because of IRQCHIP_ONESHOT_SAFE disabling
> > the forced oneshot (the other irq was pciehp). Given that these are
> > pcie-specific, do they ever get used without MSI (which sets
> > IRQCHIP_ONESHOT_SAFE)[1]?
>
> It seems fragile to depend on IRQCHIP_ONESHOT_SAFE. What about irqchips
> which don't set that? What about PCIe ports which use legacy INTx
> instead of MSI?
exactly.
> Long story short, I'll respin the patch to reduce the forced secondary
> thread's priority, taking into account Thomas' feedback.
> (Apologies for not having done this earlier.)
no worries, thanks for the spin up.
> Thanks,
>
> Lukas
Sebastian
prev parent reply other threads:[~2025-10-27 8:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-08 16:08 [PATCH] genirq/manage: Reduce priority of forced secondary IRQ handler Lukas Wunner
2025-09-17 14:56 ` Sebastian Andrzej Siewior
2025-09-20 21:20 ` Thomas Gleixner
2025-09-21 13:12 ` Lukas Wunner
2025-09-21 18:15 ` Thomas Gleixner
2025-10-03 18:25 ` Crystal Wood
2025-10-24 13:33 ` Sebastian Andrzej Siewior
2025-10-24 21:00 ` Crystal Wood
2025-10-27 6:40 ` Lukas Wunner
2025-10-27 8:18 ` Sebastian Andrzej Siewior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251027081806.qoogsX3l@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=afazekas@redhat.com \
--cc=bsegall@google.com \
--cc=clrkwllms@kernel.org \
--cc=crwood@redhat.com \
--cc=dietmar.eggemann@arm.com \
--cc=helgaas@kernel.org \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rt-devel@lists.linux.dev \
--cc=lukas@wunner.de \
--cc=mahesh@linux.ibm.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=oohall@gmail.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).