From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6EBB30AAC7 for ; Mon, 27 Oct 2025 14:56:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761576990; cv=none; b=tlR9poeQOeUiAqPdAv1Rg6lyUXI6lnbAfdFhzyCnT1oOlMLapSiYe5zatQyYJugIVpdv4tpZbMdP/BgIv6hDtHblV521NjqoKG+KwpBxRP013I2bmMU+omGM7rQtPQD7lK9Mx3u6YdRh20VdQePx8YV++rDwd8//QWftPh7OFMU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761576990; c=relaxed/simple; bh=ZMvU9vgiZOue6RqoRRXtEPG2qKfvC9tNvt6emuXOSvc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qg23lWEZO6uItP7DZ0o7wYsqV/CH4b1SGOMG7T73nd8FF24TVKXB3Db17Ew+hgcSkyedsLP+02gjVlvaqtPIQBIr3Ky/l0VlFzCk7o7ykMy5SMp+c47JCyHAI3bp/pWWtqd2daD0kq9I6M31LyQMKZUoBK13Gh2lwnue2h/gUk8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NmEOFQfM; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NmEOFQfM" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-781206cce18so4720353b3a.0 for ; Mon, 27 Oct 2025 07:56:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761576988; x=1762181788; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XJHpdmr2NXtFEk3A9X9aIw2etVmtC3q73hrlmlo4/OE=; b=NmEOFQfMVTuQ5SdLyCnWxz4r93dcYCWzXQ69xihuCmAcHq/tr2HcfKs8f1IhJ01rhA +t0cVxiyBebVtD75t0odqyGcIbJS6Dy+ri1BJn3KBEkHP7V3BVP5AMQ7tAiZZ+b2KmrZ d6o5Nkz2Ik9R5Ldc3VfyMMFu2RLeqctFOOOLjG35YSnXpprt63LDSCFUAhg9JrmRAHx/ 1f0KTBZSoDo07aQkQIYsulmAIv1/ZlE7+fnh8bw2SXKpWIAJA+7avBz/4h6CfpGKJY3O UlOqzSzz9IPL/PXP93edmU83xUgkmarcAcsc/IZsgBsZvfkTKCYCD9nczFtVb3vnam7U 1F7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761576988; x=1762181788; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XJHpdmr2NXtFEk3A9X9aIw2etVmtC3q73hrlmlo4/OE=; b=EDCk4w70l51NDU4OLcY4G9ZfEZ2lWiV3wo2aIJMcW4DXLfCSGZjVfiVHCAL9y6zJkw WinYOJC7z3jGQvzDfoq25dS7wsLE6ZzJBAOb3w9v0NqHCZnQ4tpQpUxPqBIbIpqLSGkJ K7chQd3jcr4il1moAYSXkaPU2L9zfJxJRhTJ+Gt2SEesPdulwqhemYCEnVQdeVJgiDeN JNwSnYAMQ51ZrdoLTekEvkX7vC8z5ieq4tRiaitXuQZS/I14Uiw6YhurkjN682nYy8+b 8hGqpsx3vRrBNu9G898aS+HZc0K2J4bvk3k0tIH9+2ljgGli6x5AFIn0hIHFcIPjBuJ9 YsqA== X-Forwarded-Encrypted: i=1; AJvYcCVmGMdCEfXD1bevUfq6pHJrnD6wm0fvAjH1jGlszIxXeBNysCdAnJ/IMW4n9yvnwUxDchG8aspOCfA=@vger.kernel.org X-Gm-Message-State: AOJu0Yz2BDHu9fdB5RFlzTmOjpGpLfzEltFJ5h442cw0cLaAe+qgoYTf q1j6WDID/1Pu6QbkBr2O2qnjOexYDNEaY3luorzEb97c+CbwZcFyIx1n X-Gm-Gg: ASbGnctfi8QoojQo93w8Bfx9vKbFuxS+TgtYADS9mN3U2GOb4bbthNKedwwtaj2OuLh Cn+z5VqkWs9WO17QbkNbXxPyw43Sf2GYWslfjfZaFFMKOnydhqdNJOq61LYFVbkruLOUEFfh1YT vbTFNzYYCyiI36BXUFvA5qW+eH8SH0Oj1dyrpTvwqTW7PQPkQwlgoHncYHlqdZ2Riqxm/AkmUpg 9kfqgUXSnaAzFVM6nzxKcMwnsXVQpgWObfcwBX24Wrvy73S3O8i3ymvP5H8+OIciZ86zzrBC7zA DkK7TZO2QFkAP7Ei85Zl5SE5cW9FxrmKuHdAFkaxp4TnakgYqrookfJo3C7s5rZrKqk7BwcAva3 ozpV+RBkrhHLTPJ56AQcHuPbshSRGnTi9SXtQvw3yyJaHKw+2Cu3tm90H95IdiXLUq4KlZAxBuA == X-Google-Smtp-Source: AGHT+IFpo+vKMKtPf87tmaXVzNFkUX+AxdjSTgekyu9iCoaPZB3m/DdveKL6EgBsKmZAINobovUjew== X-Received: by 2002:a05:6a00:6d48:10b0:76b:ecf2:7ece with SMTP id d2e1a72fcca58-7a284df06aamr11245249b3a.12.1761576987961; Mon, 27 Oct 2025 07:56:27 -0700 (PDT) Received: from rockpi-5b ([45.112.0.108]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7a414012b19sm8373372b3a.12.2025.10.27.07.56.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Oct 2025 07:56:27 -0700 (PDT) From: Anand Moon To: Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner , Niklas Cassel , Shawn Lin , Hans Zhang <18255117159@163.com>, Nicolas Frattaroli , linux-pci@vger.kernel.org (open list:PCI NATIVE HOST BRIDGE AND ENDPOINT DRIVERS), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Rockchip SoC support), linux-rockchip@lists.infradead.org (open list:ARM/Rockchip SoC support), linux-kernel@vger.kernel.org (open list) Cc: Anand Moon Subject: [PATCH v1 2/2] PCI: dw-rockchip: Add runtime PM support to Rockchip PCIe driver Date: Mon, 27 Oct 2025 20:25:30 +0530 Message-ID: <20251027145602.199154-3-linux.amoon@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251027145602.199154-1-linux.amoon@gmail.com> References: <20251027145602.199154-1-linux.amoon@gmail.com> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add runtime power management support to the Rockchip DesignWare PCIe controller driver by enabling devm_pm_runtime() in the probe function. These changes allow the PCIe controller to suspend and resume dynamically, improving power efficiency on supported platforms. Signed-off-by: Anand Moon --- drivers/pci/controller/dwc/pcie-dw-rockchip.c | 21 +++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/drivers/pci/controller/dwc/pcie-dw-rockchip.c b/drivers/pci/controller/dwc/pcie-dw-rockchip.c index b878ae8e2b3e..5026598d09f8 100644 --- a/drivers/pci/controller/dwc/pcie-dw-rockchip.c +++ b/drivers/pci/controller/dwc/pcie-dw-rockchip.c @@ -20,6 +20,7 @@ #include #include #include +#include #include #include @@ -690,6 +691,20 @@ static int rockchip_pcie_probe(struct platform_device *pdev) if (ret) goto deinit_phy; + ret = pm_runtime_set_suspended(dev); + if (ret) + goto disable_pm_runtime; + + ret = devm_pm_runtime_enable(dev); + if (ret) { + ret = dev_err_probe(dev, ret, "Failed to enable runtime PM\n"); + goto deinit_clk; + } + + ret = pm_runtime_resume_and_get(dev); + if (ret) + goto disable_pm_runtime; + switch (data->mode) { case DW_PCIE_RC_TYPE: ret = rockchip_pcie_configure_rc(pdev, rockchip); @@ -709,7 +724,10 @@ static int rockchip_pcie_probe(struct platform_device *pdev) return 0; +disable_pm_runtime: + pm_runtime_disable(dev); deinit_clk: + pm_runtime_no_callbacks(dev); clk_bulk_disable_unprepare(rockchip->clk_cnt, rockchip->clks); deinit_phy: rockchip_pcie_phy_deinit(rockchip); @@ -725,6 +743,9 @@ static void rockchip_pcie_remove(struct platform_device *pdev) /* Perform other cleanups as necessary */ clk_bulk_disable_unprepare(rockchip->clk_cnt, rockchip->clks); rockchip_pcie_phy_deinit(rockchip); + pm_runtime_put_sync(dev); + pm_runtime_disable(dev); + pm_runtime_no_callbacks(dev); } static const struct rockchip_pcie_of_data rockchip_pcie_rc_of_data_rk3568 = { -- 2.50.1