From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3992F26CE3A; Mon, 27 Oct 2025 23:28:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761607730; cv=none; b=QpD2YOQo2boN3wugUo4PG9feMZppPVEdWVJgWJVGDdWEySc9Ha1F9rrvFXzUsb/AZXzI1EZNM9vZFPHhr2nJipu5OJgYO0p0LubJGZ0ziGH5Wvbk4yngp0sIuzIQ5agXjyNkZ7Tu+fOFFVWg4x0Uai2WIRY4jAcV/wyX10IGyAY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761607730; c=relaxed/simple; bh=IZicGIZudhpTlaLtDGw3tQ8v1+Qu3XNy8z2ox6X1Lmc=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=IQLQU/zmkSGaJjEKIAQymJaCBp1kyTmwIRN/aWBL/VHdPgQOHSbZrXx/Bl/dTTjRnef/hoMooSae8KNYF1i8OmoF3ukwDXLXc3fRAd3R20sxHtc3VcmeBNjPR4vA3ehnzFP/DqpH8C2zCyNHy1tYTNZ7hIWRhQqmtay/TueOdcM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PiFNHfry; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PiFNHfry" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE2F4C4CEF1; Mon, 27 Oct 2025 23:28:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1761607728; bh=IZicGIZudhpTlaLtDGw3tQ8v1+Qu3XNy8z2ox6X1Lmc=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=PiFNHfryYS/YIt0hkuSoUELksbIx5CgbaCoOsWKsTZy8XuPdbvwEt17B6mdKGMCDC gzTBV42gtXZjpbfBU6iKCY/D6/5blAEIlfL4bM+EsDVEbmSP6IUkEsFy9ANb6yLsUC QiqBEreLqslMhY/VQ5IWgBLhI5VfXoef11yPBA7pyk0rMg5sYUTTE25/MnkJIowYaQ 4a3O5Z5qE4aNdLnkxaAxinz5KB1WIxHhdln95ku/yn35Ip+zAvLMxS1TmGEZlfNn9c c7NrbnGtU8klBdQnDOQdZwzibxzH8B4ZlcI5xdoBCuSqPRcm3cifMyFDpHow0NDB/L 3daJIROy80RJw== Date: Mon, 27 Oct 2025 18:28:47 -0500 From: Bjorn Helgaas To: Manivannan Sadhasivam Cc: thippeswamy.havalige@amd.com, Ravi Kumar Bandi , lpieralisi@kernel.org, bhelgaas@google.com, linux-pci@vger.kernel.org, kwilczynski@kernel.org, robh@kernel.org, michal.simek@amd.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Stefan Roese , "Musham, Sai Krishna" , Sean Anderson , "Yeleswarapu, Nagaradhesh" Subject: Re: [PATCH v2] PCI: xilinx-xdma: Enable INTx interrupts Message-ID: <20251027232847.GA1488235@bhelgaas> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <176085776570.12994.10687348823390647832.b4-ty@kernel.org> [+cc Stefan et al] On Sun, Oct 19, 2025 at 12:39:25PM +0530, Manivannan Sadhasivam wrote: > On Sat, 20 Sep 2025 22:52:32 +0000, Ravi Kumar Bandi wrote: > > The pcie-xilinx-dma-pl driver does not enable INTx interrupts > > after initializing the port, preventing INTx interrupts from > > PCIe endpoints from flowing through the Xilinx XDMA root port > > bridge. This issue affects kernel 6.6.0 and later versions. > > > > This patch allows INTx interrupts generated by PCIe endpoints > > to flow through the root port. Tested the fix on a board with > > two endpoints generating INTx interrupts. Interrupts are > > properly detected and serviced. The /proc/interrupts output > > shows: > > > > [...] > > Applied, thanks! > > [1/1] PCI: xilinx-xdma: Enable INTx interrupts > commit: c098c13f4365e6750009be4d90dba36fa4a19b4e Pretty sure we have confirmation that we don't need either this patch or Stefan's patch, so I removed the pci/controller/xilinx-dma branch. It was at 2002478e5034 ("PCI: xilinx-xdma: Enable INTx interrupts") in case we need to resurrect it. IIUC, Stefan confirmed that he didn't need this patch (Ravi's) [1], and that after Vivado is fixed to generate the correct interrupt-map, his patch (Stefan's) won't be needed either [2]. [1] https://lore.kernel.org/r/29bc5e92-04c9-475a-ba3d-a5ea26f1c95a@mailbox.org [2] https://lore.kernel.org/r/9c7e43c3-24e9-4b08-a6ce-2035b50226f4@mailbox.org