Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Linnaea Lavia <linnaea-von-lavia@live.com>
Cc: FUKAUMI Naoki <naoki@radxa.com>,
	"linux-amlogic@lists.infradead.org"
	<linux-amlogic@lists.infradead.org>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	regressions@lists.linux.dev, Yue Wang <yue.wang@amlogic.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Kevin Hilman <khilman@baylibre.com>,
	Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
Subject: Re: PCIe probe failure on AmLogic A311D after 6.18-rc1
Date: Wed, 29 Oct 2025 12:15:42 -0500	[thread overview]
Message-ID: <20251029171542.GA1566240@bhelgaas> (raw)
In-Reply-To: <DM4PR05MB1027063F8AA9069B66A632C2EC7FAA@DM4PR05MB10270.namprd05.prod.outlook.com>

On Wed, Oct 29, 2025 at 06:50:46PM +0800, Linnaea Lavia wrote:
> On 10/29/2025 6:16 AM, Bjorn Helgaas wrote:

> > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> > index 214ed060ca1b..9cd12924b5cb 100644
> > --- a/drivers/pci/quirks.c
> > +++ b/drivers/pci/quirks.c
> > @@ -2524,6 +2524,7 @@ static void quirk_disable_aspm_l0s_l1(struct pci_dev *dev)
> >    * disable both L0s and L1 for now to be safe.
> >    */
> >   DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ASMEDIA, 0x1080, quirk_disable_aspm_l0s_l1);
> > +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_SYNOPSYS, 0xabcd, quirk_disable_aspm_l0s_l1);
> >   /*
> >    * Some Pericom PCIe-to-PCI bridges in reverse mode need the PCIe Retrain
> 
> I have applied the patch on 6.18-rc3 but it's still trying to enable ASPM for some reasons.

Sorry, my fault, I should have made that fixup run earlier, so the
patch should be this instead:

diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 214ed060ca1b..4fc04015ca0c 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -2524,6 +2524,7 @@ static void quirk_disable_aspm_l0s_l1(struct pci_dev *dev)
  * disable both L0s and L1 for now to be safe.
  */
 DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ASMEDIA, 0x1080, quirk_disable_aspm_l0s_l1);
+DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_SYNOPSYS, 0xabcd, quirk_disable_aspm_l0s_l1);

  reply	other threads:[~2025-10-29 17:15 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-23 11:33 PCIe probe failure on AmLogic A311D after 6.18-rc1 Linnaea Lavia
2025-10-23 16:42 ` Bjorn Helgaas
2025-10-24  3:27   ` Linnaea Lavia
2025-10-27 12:51     ` FUKAUMI Naoki
2025-10-27 18:19       ` Linnaea Lavia
2025-10-28 22:16         ` Bjorn Helgaas
2025-10-29 10:50           ` Linnaea Lavia
2025-10-29 17:15             ` Bjorn Helgaas [this message]
2025-10-31  5:34               ` Linnaea Lavia
2025-10-31  8:50                 ` Neil Armstrong
2025-10-31 12:26                   ` Linnaea Lavia
2025-10-31 16:13                     ` Bjorn Helgaas
2025-10-31 17:47                       ` Manivannan Sadhasivam
2025-11-01  2:26                         ` Linnaea Lavia
2025-11-01  2:23                       ` Linnaea Lavia
2025-11-03  9:51                       ` Neil Armstrong
2025-10-30 22:34   ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251029171542.GA1566240@bhelgaas \
    --to=helgaas@kernel.org \
    --cc=khilman@baylibre.com \
    --cc=krishna.chundru@oss.qualcomm.com \
    --cc=linnaea-von-lavia@live.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=naoki@radxa.com \
    --cc=neil.armstrong@linaro.org \
    --cc=regressions@lists.linux.dev \
    --cc=yue.wang@amlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox