From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7657133BBBF; Tue, 4 Nov 2025 17:53:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762278794; cv=none; b=VxyBo/joDbFtN9uo40kjeqQpioRZDWR0imeBd6K6+324EmGIivUXmIaNg1jEFPfBYN7TRakJsAis7inzqz7Myqf3vcYw7o6fMedXO44bizizYVreyFQbo0sBq7FVEp7D+ZuTGLIt1Xny8OqfnjvbXdbb1sZYLpm1eS3To+mLo+A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762278794; c=relaxed/simple; bh=cjmiyzaFtvZ6vT4eZJAXmc9f8mbTNZEMaQHhbrN3eRs=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=KQbutbRKdXwzeX2kvCNmx0geWxfr8oZgLm+qr3dPGo8sQYOTd15Mum/3x5xCj55zsW4ImHPoDgXO2VmqpSXwRcUv37RzsvU1DHXup2gZ5fSsxQBQoUbclGGYKMfA+GtDv1CW8WEoGxe8P83vq/6DWJ1ZNjEwjYN1bqKCZTFMyIM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTPS id 4d1GJL1TxQzJ4692; Wed, 5 Nov 2025 01:52:50 +0800 (CST) Received: from dubpeml100005.china.huawei.com (unknown [7.214.146.113]) by mail.maildlp.com (Postfix) with ESMTPS id 10C17140278; Wed, 5 Nov 2025 01:53:10 +0800 (CST) Received: from localhost (10.203.177.15) by dubpeml100005.china.huawei.com (7.214.146.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Tue, 4 Nov 2025 17:53:09 +0000 Date: Tue, 4 Nov 2025 17:53:07 +0000 From: Jonathan Cameron To: Terry Bowman CC: , , , , , , , , , , , , , , , , , , Subject: Re: [RESEND v13 03/25] cxl/pci: Remove unnecessary CXL Endpoint handling helper functions Message-ID: <20251104175307.00000132@huawei.com> In-Reply-To: <20251104170305.4163840-4-terry.bowman@amd.com> References: <20251104170305.4163840-1-terry.bowman@amd.com> <20251104170305.4163840-4-terry.bowman@amd.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml100011.china.huawei.com (7.191.174.247) To dubpeml100005.china.huawei.com (7.214.146.113) On Tue, 4 Nov 2025 11:02:43 -0600 Terry Bowman wrote: > The CXL driver's cxl_handle_endpoint_cor_ras()/cxl_handle_endpoint_ras() > are unnecessary helper functions used only for Endpoints. Remove these > functions as they are not common for all CXL devices and do not provide > value for EP handling. > > Rename __cxl_handle_ras to cxl_handle_ras() and __cxl_handle_cor_ras() > to cxl_handle_cor_ras(). > > Signed-off-by: Terry Bowman > Reviewed-by: Kuppuswamy Sathyanarayanan > Reviewed-by: Jonathan Cameron > Reviewed-by: Dave Jiang > > Changes in v12->v13: Change log needs to go below the --- as we don't want it in the git history. > - None