From: Andrea della Porta <andrea.porta@suse.com>
To: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
mbrugger@suse.com, guillaume.gardet@arm.com, tiwai@suse.com,
Lizhi Hou <lizhi.hou@amd.com>, Rob Herring <robh@kernel.org>
Cc: Andrea della Porta <andrea.porta@suse.com>
Subject: [PATCH v4] PCI: of: Drop error message on missing of_root node
Date: Mon, 10 Nov 2025 12:21:10 +0100 [thread overview]
Message-ID: <20251110112110.10620-1-andrea.porta@suse.com> (raw)
When CONFIG_PCI_DYNAMIC_OF_NODES is enabled, an error message
is generated if no 'of_root' node is defined.
On DT-based systems, this cannot happen as a root DT node is
always present.
On ACPI-based systems that declare an empty root DT node (e.g.
x86 with CONFIG_OF_EARLY_FLATTREE=y), this also won't happen.
On platforms where ACPI is mutually exclusive to DT (e.g. ARM)
the error will be caught (and possibly shown) by drivers that
rely on the root node.
Drop the error message altogether.
Signed-off-by: Andrea della Porta <andrea.porta@suse.com>
---
CHANGES in V4:
- dropped {} from the single line conditional body
V3: https://lore.kernel.org/all/20251110105415.9584-1-andrea.porta@suse.com/
---
drivers/pci/of.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/pci/of.c b/drivers/pci/of.c
index 3579265f1198..c222944eec40 100644
--- a/drivers/pci/of.c
+++ b/drivers/pci/of.c
@@ -774,10 +774,8 @@ void of_pci_make_host_bridge_node(struct pci_host_bridge *bridge)
}
/* Check if there is a DT root node to attach the created node */
- if (!of_root) {
- pr_err("of_root node is NULL, cannot create PCI host bridge node\n");
+ if (!of_root)
return;
- }
name = kasprintf(GFP_KERNEL, "pci@%x,%x", pci_domain_nr(bridge->bus),
bridge->bus->number);
--
2.35.3
reply other threads:[~2025-11-10 11:18 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251110112110.10620-1-andrea.porta@suse.com \
--to=andrea.porta@suse.com \
--cc=bhelgaas@google.com \
--cc=guillaume.gardet@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lizhi.hou@amd.com \
--cc=mbrugger@suse.com \
--cc=robh@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).