linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v4] PCI: of: Drop error message on missing of_root node
@ 2025-11-10 11:21 Andrea della Porta
  0 siblings, 0 replies; only message in thread
From: Andrea della Porta @ 2025-11-10 11:21 UTC (permalink / raw)
  To: Bjorn Helgaas, linux-pci, linux-kernel, mbrugger,
	guillaume.gardet, tiwai, Lizhi Hou, Rob Herring
  Cc: Andrea della Porta

When CONFIG_PCI_DYNAMIC_OF_NODES is enabled, an error message
is generated if no 'of_root' node is defined.

On DT-based systems, this cannot happen as a root DT node is
always present.
On ACPI-based systems that declare an empty root DT node (e.g.
x86 with CONFIG_OF_EARLY_FLATTREE=y), this also won't happen.
On platforms where ACPI is mutually exclusive to DT (e.g. ARM)
the error will be caught (and possibly shown) by drivers that
rely on the root node.

Drop the error message altogether.

Signed-off-by: Andrea della Porta <andrea.porta@suse.com>
---
CHANGES in V4:
- dropped {} from the single line conditional body

V3: https://lore.kernel.org/all/20251110105415.9584-1-andrea.porta@suse.com/
---
 drivers/pci/of.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/pci/of.c b/drivers/pci/of.c
index 3579265f1198..c222944eec40 100644
--- a/drivers/pci/of.c
+++ b/drivers/pci/of.c
@@ -774,10 +774,8 @@ void of_pci_make_host_bridge_node(struct pci_host_bridge *bridge)
 	}
 
 	/* Check if there is a DT root node to attach the created node */
-	if (!of_root) {
-		pr_err("of_root node is NULL, cannot create PCI host bridge node\n");
+	if (!of_root)
 		return;
-	}
 
 	name = kasprintf(GFP_KERNEL, "pci@%x,%x", pci_domain_nr(bridge->bus),
 			 bridge->bus->number);
-- 
2.35.3


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2025-11-10 11:18 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-10 11:21 [PATCH v4] PCI: of: Drop error message on missing of_root node Andrea della Porta

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).