* [PATCH v1 1/1] PCI: stm32-ep: Don't use "proxy" headers
@ 2025-11-12 8:56 Andy Shevchenko
2025-11-14 9:37 ` Christian Bruel
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2025-11-12 8:56 UTC (permalink / raw)
To: Christian Bruel, Andy Shevchenko, linux-pci, linux-stm32,
linux-arm-kernel, linux-kernel
Cc: Lorenzo Pieralisi, Krzysztof Wilczyński,
Manivannan Sadhasivam, Rob Herring, Bjorn Helgaas,
Maxime Coquelin, Alexandre Torgue
Update header inclusions to follow IWYU (Include What You Use)
principle.
In this case replace of_gpio.h, which is subject to remove by the GPIOLIB
subsystem, with the respective headers that are being used by the driver.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/pci/controller/dwc/pcie-stm32-ep.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/controller/dwc/pcie-stm32-ep.c b/drivers/pci/controller/dwc/pcie-stm32-ep.c
index 3400c7cd2d88..2b9b451306fc 100644
--- a/drivers/pci/controller/dwc/pcie-stm32-ep.c
+++ b/drivers/pci/controller/dwc/pcie-stm32-ep.c
@@ -7,9 +7,9 @@
*/
#include <linux/clk.h>
+#include <linux/gpio/consumer.h>
#include <linux/mfd/syscon.h>
#include <linux/of_platform.h>
-#include <linux/of_gpio.h>
#include <linux/phy/phy.h>
#include <linux/platform_device.h>
#include <linux/pm_runtime.h>
--
2.50.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1 1/1] PCI: stm32-ep: Don't use "proxy" headers
2025-11-12 8:56 [PATCH v1 1/1] PCI: stm32-ep: Don't use "proxy" headers Andy Shevchenko
@ 2025-11-14 9:37 ` Christian Bruel
0 siblings, 0 replies; 2+ messages in thread
From: Christian Bruel @ 2025-11-14 9:37 UTC (permalink / raw)
To: Andy Shevchenko, linux-pci, linux-stm32, linux-arm-kernel,
linux-kernel
Cc: Lorenzo Pieralisi, Krzysztof Wilczyński,
Manivannan Sadhasivam, Rob Herring, Bjorn Helgaas,
Maxime Coquelin, Alexandre Torgue
Hello,
On 11/12/25 09:56, Andy Shevchenko wrote:
> Update header inclusions to follow IWYU (Include What You Use)
> principle.
>
> In this case replace of_gpio.h, which is subject to remove by the GPIOLIB
> subsystem, with the respective headers that are being used by the driver.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/pci/controller/dwc/pcie-stm32-ep.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/dwc/pcie-stm32-ep.c b/drivers/pci/controller/dwc/pcie-stm32-ep.c
> index 3400c7cd2d88..2b9b451306fc 100644
> --- a/drivers/pci/controller/dwc/pcie-stm32-ep.c
> +++ b/drivers/pci/controller/dwc/pcie-stm32-ep.c
> @@ -7,9 +7,9 @@
> */
>
> #include <linux/clk.h>
> +#include <linux/gpio/consumer.h>
> #include <linux/mfd/syscon.h>
> #include <linux/of_platform.h>
> -#include <linux/of_gpio.h>
> #include <linux/phy/phy.h>
> #include <linux/platform_device.h>
> #include <linux/pm_runtime.h>
<linux/gpio/consumer.h> is already included from pcie-designware.h
However, if it is still required for IWYU, could you kindly include it
in pcie-stm32.c as well while you are working on it?
Thank you very much
Christian
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-11-14 9:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-12 8:56 [PATCH v1 1/1] PCI: stm32-ep: Don't use "proxy" headers Andy Shevchenko
2025-11-14 9:37 ` Christian Bruel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).