Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Dhruva Gole <d-gole@ti.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Linux PM <linux-pm@vger.kernel.org>,
	Linux ACPI <linux-acpi@vger.kernel.org>,
	Jonathan Cameron <jonathan.cameron@huawei.com>,
	Takashi Iwai <tiwai@suse.de>, LKML <linux-kernel@vger.kernel.org>,
	"Zhang Qilong" <zhangqilong3@huawei.com>,
	Frank Li <Frank.Li@nxp.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Linux PCI <linux-pci@vger.kernel.org>,
	"Bjorn Helgaas" <helgaas@kernel.org>
Subject: Re: [PATCH v2 3/3] PCI/sysfs: Use PM_RUNTIME_ACQUIRE()/PM_RUNTIME_ACQUIRE_ERR()
Date: Fri, 14 Nov 2025 14:32:53 +0530	[thread overview]
Message-ID: <20251114090253.n5m43jdvg5rv2bbb@lcpd911> (raw)
In-Reply-To: <3932581.kQq0lBPeGt@rafael.j.wysocki>

On Nov 13, 2025 at 20:35:27 +0100, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> Use new PM_RUNTIME_ACQUIRE() and PM_RUNTIME_ACQUIRE_ERR() wrapper macros
> to make the code look more straightforward.
> 
> No intentional funtional impact.

Same here ...

Reviewed-by: Dhruva Gole <d-gole@ti.com> 

> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
> 
> v1 -> v2: Adjust to the changes in patch [1/3].
> 
> ---
>  drivers/pci/pci-sysfs.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- a/drivers/pci/pci-sysfs.c
> +++ b/drivers/pci/pci-sysfs.c
> @@ -1517,8 +1517,8 @@ static ssize_t reset_method_store(struct
>  		return count;
>  	}
>  
> -	ACQUIRE(pm_runtime_active_try, pm)(dev);
> -	if (ACQUIRE_ERR(pm_runtime_active_try, &pm))
> +	PM_RUNTIME_ACQUIRE(dev, pm);
> +	if (PM_RUNTIME_ACQUIRE_ERR(&pm))
>  		return -ENXIO;
>  
>  	if (sysfs_streq(buf, "default")) {
> 
> 
> 

-- 
Best regards,
Dhruva Gole
Texas Instruments Incorporated

  reply	other threads:[~2025-11-14  9:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-13 19:24 [PATCH v2 0/3] PM: runtime: Wrapper macros for usage counter guards Rafael J. Wysocki
2025-11-13 19:33 ` [PATCH v2 1/3] PM: runtime: Wrapper macros for ACQUIRE()/ACQUIRE_ERR() Rafael J. Wysocki
2025-11-14  8:53   ` Dhruva Gole
2025-11-14 20:15   ` Frank Li
2025-11-13 19:34 ` [PATCH v2 2/3] ACPI: TAD: Use PM_RUNTIME_ACQUIRE()/PM_RUNTIME_ACQUIRE_ERR() Rafael J. Wysocki
2025-11-14  9:02   ` Dhruva Gole
2025-11-13 19:35 ` [PATCH v2 3/3] PCI/sysfs: " Rafael J. Wysocki
2025-11-14  9:02   ` Dhruva Gole [this message]
2025-11-14 15:47     ` Rafael J. Wysocki
2025-11-14 13:10 ` [PATCH v2 0/3] PM: runtime: Wrapper macros for usage counter guards Jonathan Cameron
2025-11-14 15:49   ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251114090253.n5m43jdvg5rv2bbb@lcpd911 \
    --to=d-gole@ti.com \
    --cc=Frank.Li@nxp.com \
    --cc=dan.j.williams@intel.com \
    --cc=helgaas@kernel.org \
    --cc=jonathan.cameron@huawei.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=tiwai@suse.de \
    --cc=zhangqilong3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox