Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Hans Zhang <Hans.Zhang@cixtech.com>
Cc: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
	"lpieralisi@kernel.org" <lpieralisi@kernel.org>,
	"kwilczynski@kernel.org" <kwilczynski@kernel.org>,
	"mani@kernel.org" <mani@kernel.org>,
	"robh@kernel.org" <robh@kernel.org>,
	"bhelgaas@google.com" <bhelgaas@google.com>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Abaci Robot <abaci@linux.alibaba.com>,
	Manikandan Karunakaran Pillai <mpillai@cadence.com>
Subject: Re: 回复: [PATCH -next] PCI: cadence: remove unneeded semicolon
Date: Mon, 24 Nov 2025 12:02:55 -0600	[thread overview]
Message-ID: <20251124180255.GA2700418@bhelgaas> (raw)
In-Reply-To: <KL1PR0601MB472685FE5109782EF14C62DB9DD4A@KL1PR0601MB4726.apcprd06.prod.outlook.com>

On Thu, Nov 20, 2025 at 09:41:43AM +0000, Hans Zhang wrote:
> + Manikandan
> 
> -----邮件原件-----
> 发件人: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> 
> 发送时间: 2025年11月20日 17:35
> 收件人: lpieralisi@kernel.org
> 抄送: kwilczynski@kernel.org; mani@kernel.org; robh@kernel.org; bhelgaas@google.com; linux-pci@vger.kernel.org; linux-kernel@vger.kernel.org; Jiapeng Chong <jiapeng.chong@linux.alibaba.com>; Abaci Robot <abaci@linux.alibaba.com>
> 主题: [PATCH -next] PCI: cadence: remove unneeded semicolon
> 
> [You don't often get email from jiapeng.chong@linux.alibaba.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> EXTERNAL EMAIL
> 
> No functional modification involved.
> 
> ./drivers/pci/controller/cadence/pcie-cadence.h:217:2-3: Unneeded semicolon.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=27326
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

Squashed this into the commit (f5fa6c33b173 ("PCI: cadence: Add
support for High Perf Architecture (HPA) controller"), no need to
repost this.

There's a rash of this error.  Do you know of any others in
drivers/pci/?

> ---
>  drivers/pci/controller/cadence/pcie-cadence.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/cadence/pcie-cadence.h b/drivers/pci/controller/cadence/pcie-cadence.h
> index 717921411ed9..311a13ae46e7 100644
> --- a/drivers/pci/controller/cadence/pcie-cadence.h
> +++ b/drivers/pci/controller/cadence/pcie-cadence.h
> @@ -214,7 +214,7 @@ static inline u32 cdns_reg_bank_to_off(struct cdns_pcie *pcie, enum cdns_pcie_re
>                 break;
>         default:
>                 break;
> -       };
> +       }
>         return offset;
>  }
> 
> --
> 2.43.5
> 
> 

      reply	other threads:[~2025-11-24 18:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-20  9:35 [PATCH -next] PCI: cadence: remove unneeded semicolon Jiapeng Chong
2025-11-20  9:41 ` 回复: " Hans Zhang
2025-11-24 18:02   ` Bjorn Helgaas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251124180255.GA2700418@bhelgaas \
    --to=helgaas@kernel.org \
    --cc=Hans.Zhang@cixtech.com \
    --cc=abaci@linux.alibaba.com \
    --cc=bhelgaas@google.com \
    --cc=jiapeng.chong@linux.alibaba.com \
    --cc=kwilczynski@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=mani@kernel.org \
    --cc=mpillai@cadence.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox