From: Jason Gunthorpe <jgg@ziepe.ca>
To: Manivannan Sadhasivam <mani@kernel.org>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
iommu@lists.linux.dev, Naresh Kamboju <naresh.kamboju@linaro.org>,
Pavankumar Kondeti <quic_pkondeti@quicinc.com>,
Xingang Wang <wangxingang5@huawei.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH v2 3/4] PCI: Disable ACS SV capability for the broken IDT switches
Date: Wed, 17 Dec 2025 11:19:52 -0400 [thread overview]
Message-ID: <20251217151952.GG31492@ziepe.ca> (raw)
In-Reply-To: <4d3asssmv5xkttasl2xl2f6q3l5ki4jxmsrbyy6hvrd7djgsnj@y7drlazpwzi3>
On Tue, Dec 09, 2025 at 08:20:39PM +0900, Manivannan Sadhasivam wrote:
> On Tue, Dec 02, 2025 at 03:15:33PM -0400, Jason Gunthorpe wrote:
> > On Tue, Dec 02, 2025 at 07:52:50PM +0530, Manivannan Sadhasivam wrote:
> > > @@ -544,6 +544,7 @@ struct pci_dev {
> > > #endif
> > > u16 acs_cap; /* ACS Capability offset */
> > > u16 acs_capabilities; /* ACS Capabilities */
> > > + u16 acs_broken_cap; /* Broken ACS Capabilities */
> >
> > Why do we need this? Have the quirk function accep tthe
> > acs_capabilities from the register and return the value to program
> > into struct pci_dev ?
> >
>
> We dont have any quirk levels between pci_acs_init() and pci_acs_enable() that
> will allow us to modify pci_dev::acs_capabilities in the quirk function. Hence,
> I came up with one more member to pass the broken caps.
Call the quirk function directly from the ACS path? We have things
like that already for ACS?
Jason
next prev parent reply other threads:[~2025-12-17 15:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20251202142307eucas1p12a15e5656bb53f48f445c3056d4e3166@eucas1p1.samsung.com>
2025-12-02 14:22 ` [PATCH v2 0/4] PCI: Fix ACS enablement for Root Ports in OF platforms Manivannan Sadhasivam
2025-12-02 14:22 ` [PATCH v2 1/4] PCI: Enable ACS only after configuring IOMMU for " Manivannan Sadhasivam
2025-12-02 14:22 ` [PATCH v2 2/4] PCI: Cache ACS capabilities Manivannan Sadhasivam
2025-12-02 14:22 ` [PATCH v2 3/4] PCI: Disable ACS SV capability for the broken IDT switches Manivannan Sadhasivam
2025-12-02 19:15 ` Jason Gunthorpe
2025-12-09 11:20 ` Manivannan Sadhasivam
2025-12-17 15:19 ` Jason Gunthorpe [this message]
2025-12-02 14:22 ` [PATCH v2 4/4] PCI: Extend the pci_disable_acs_sv quirk for one more IDT switch Manivannan Sadhasivam
2025-12-03 8:46 ` [PATCH v2 0/4] PCI: Fix ACS enablement for Root Ports in OF platforms Naresh Kamboju
2025-12-03 12:04 ` Marek Szyprowski
2025-12-04 13:13 ` Marek Szyprowski
2025-12-09 7:31 ` Marek Szyprowski
2025-12-09 8:28 ` Marek Szyprowski
2025-12-09 11:15 ` Manivannan Sadhasivam
2025-12-09 12:00 ` Marek Szyprowski
2025-12-09 15:04 ` Manivannan Sadhasivam
2025-12-10 17:26 ` Marek Szyprowski
2025-12-12 4:02 ` Manivannan Sadhasivam
2025-12-12 7:25 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251217151952.GG31492@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=bhelgaas@google.com \
--cc=iommu@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mani@kernel.org \
--cc=manivannan.sadhasivam@oss.qualcomm.com \
--cc=naresh.kamboju@linaro.org \
--cc=quic_pkondeti@quicinc.com \
--cc=robin.murphy@arm.com \
--cc=wangxingang5@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox