public inbox for linux-pci@vger.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Leon Romanovsky <leon@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	Alex Williamson <alex@shazbot.org>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 01/11] PCI/P2PDMA: Separate the mmap() support from the core logic
Date: Fri, 2 Jan 2026 17:40:33 -0600	[thread overview]
Message-ID: <20260102234033.GA246107@bhelgaas> (raw)
In-Reply-To: <20251120-dmabuf-vfio-v9-1-d7f71607f371@nvidia.com>

[cc list trimmed]

On Thu, Nov 20, 2025 at 11:28:20AM +0200, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@nvidia.com>
> 
> Currently the P2PDMA code requires a pgmap and a struct page to
> function. The was serving three important purposes:
> ...

> +++ b/include/linux/pci-p2pdma.h
> @@ -16,6 +16,16 @@
>  struct block_device;
>  struct scatterlist;
>  
> +/**
> + * struct p2pdma_provider
> + *
> + * A p2pdma provider is a range of MMIO address space available to the CPU.
> + */

Already upstream (f58ef9d1d135 ("PCI/P2PDMA: Separate the mmap()
support from the core logic")), but this adds kerneldoc warnings:

  Warning: include/linux/pci-p2pdma.h:26 struct member 'owner' not described in 'p2pdma_provider'
  Warning: include/linux/pci-p2pdma.h:26 struct member 'bus_offset' not described in 'p2pdma_provider'

Repro:

  $ scripts/kernel-doc -none include/linux/pci-p2pdma.h

> +struct p2pdma_provider {
> +	struct device *owner;
> +	u64 bus_offset;
> +};

  reply	other threads:[~2026-01-02 23:40 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-20  9:28 [PATCH v9 00/11] vfio/pci: Allow MMIO regions to be exported through dma-buf Leon Romanovsky
2025-11-20  9:28 ` [PATCH v9 01/11] PCI/P2PDMA: Separate the mmap() support from the core logic Leon Romanovsky
2026-01-02 23:40   ` Bjorn Helgaas [this message]
2025-11-20  9:28 ` [PATCH v9 02/11] PCI/P2PDMA: Simplify bus address mapping API Leon Romanovsky
2025-11-20  9:28 ` [PATCH v9 03/11] PCI/P2PDMA: Refactor to separate core P2P functionality from memory allocation Leon Romanovsky
2025-11-20  9:28 ` [PATCH v9 04/11] PCI/P2PDMA: Provide an access to pci_p2pdma_map_type() function Leon Romanovsky
2025-11-20  9:28 ` [PATCH v9 05/11] PCI/P2PDMA: Document DMABUF model Leon Romanovsky
2025-11-20  9:28 ` [PATCH v9 06/11] dma-buf: provide phys_vec to scatter-gather mapping routine Leon Romanovsky
2025-11-20  9:33   ` Christian König
2025-11-20 10:03     ` Leon Romanovsky
2025-11-26  0:18   ` Alex Mastro
2025-11-26 13:12     ` Pranjal Shrivastava
2025-11-26 16:08       ` Alex Mastro
2025-11-26 16:54         ` Jason Gunthorpe
2025-11-20  9:28 ` [PATCH v9 07/11] vfio: Export vfio device get and put registration helpers Leon Romanovsky
2025-11-20  9:28 ` [PATCH v9 08/11] vfio/pci: Share the core device pointer while invoking feature functions Leon Romanovsky
2025-11-20  9:28 ` [PATCH v9 09/11] vfio/pci: Enable peer-to-peer DMA transactions by default Leon Romanovsky
2025-11-20  9:28 ` [PATCH v9 10/11] vfio/pci: Add dma-buf export support for MMIO regions Leon Romanovsky
2025-11-21  0:04   ` Alex Williamson
2025-11-21  0:23     ` Jason Gunthorpe
2025-11-21  0:40       ` Alex Williamson
2025-11-21  7:42     ` Leon Romanovsky
2025-11-20  9:28 ` [PATCH v9 11/11] vfio/nvgrace: Support get_dmabuf_phys Leon Romanovsky
2025-11-20 17:13   ` Ankit Agrawal
2025-11-20 17:23 ` [PATCH v9 00/11] vfio/pci: Allow MMIO regions to be exported through dma-buf Ankit Agrawal
2025-11-21 16:24 ` Alex Williamson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260102234033.GA246107@bhelgaas \
    --to=helgaas@kernel.org \
    --cc=alex@shazbot.org \
    --cc=bhelgaas@google.com \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox