* [PATCH] PCI: meson: Drop unused WAIT_LINKUP_TIMEOUT macro
@ 2026-01-05 12:56 Martin Blumenstingl
2026-01-05 13:48 ` neil.armstrong
2026-01-05 17:26 ` Bjorn Helgaas
0 siblings, 2 replies; 3+ messages in thread
From: Martin Blumenstingl @ 2026-01-05 12:56 UTC (permalink / raw)
To: linux-amlogic, linux-pci
Cc: linux-kernel, linux-arm-kernel, bhelgaas, robh, mani, kwilczynski,
lpieralisi, yue.wang, Martin Blumenstingl
Commit 113d9712f63b ("PCI: meson: Report that link is up while in ASPM
L0s and L1 states") removed the waiting loop in meson_pcie_link_up()
making #define WAIT_LINKUP_TIMEOUT now unused.
Drop the now unused variable to keep the driver code clean.
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
drivers/pci/controller/dwc/pci-meson.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pci/controller/dwc/pci-meson.c b/drivers/pci/controller/dwc/pci-meson.c
index a1c389216362..0694084f612b 100644
--- a/drivers/pci/controller/dwc/pci-meson.c
+++ b/drivers/pci/controller/dwc/pci-meson.c
@@ -37,7 +37,6 @@
#define PCIE_CFG_STATUS17 0x44
#define PM_CURRENT_STATE(x) (((x) >> 7) & 0x1)
-#define WAIT_LINKUP_TIMEOUT 4000
#define PORT_CLK_RATE 100000000UL
#define MAX_PAYLOAD_SIZE 256
#define MAX_READ_REQ_SIZE 256
--
2.52.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] PCI: meson: Drop unused WAIT_LINKUP_TIMEOUT macro
2026-01-05 12:56 [PATCH] PCI: meson: Drop unused WAIT_LINKUP_TIMEOUT macro Martin Blumenstingl
@ 2026-01-05 13:48 ` neil.armstrong
2026-01-05 17:26 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: neil.armstrong @ 2026-01-05 13:48 UTC (permalink / raw)
To: Martin Blumenstingl, linux-amlogic, linux-pci
Cc: linux-kernel, linux-arm-kernel, bhelgaas, robh, mani, kwilczynski,
lpieralisi, yue.wang
On 1/5/26 13:56, Martin Blumenstingl wrote:
> Commit 113d9712f63b ("PCI: meson: Report that link is up while in ASPM
> L0s and L1 states") removed the waiting loop in meson_pcie_link_up()
> making #define WAIT_LINKUP_TIMEOUT now unused.
>
> Drop the now unused variable to keep the driver code clean.
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> drivers/pci/controller/dwc/pci-meson.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/controller/dwc/pci-meson.c b/drivers/pci/controller/dwc/pci-meson.c
> index a1c389216362..0694084f612b 100644
> --- a/drivers/pci/controller/dwc/pci-meson.c
> +++ b/drivers/pci/controller/dwc/pci-meson.c
> @@ -37,7 +37,6 @@
> #define PCIE_CFG_STATUS17 0x44
> #define PM_CURRENT_STATE(x) (((x) >> 7) & 0x1)
>
> -#define WAIT_LINKUP_TIMEOUT 4000
> #define PORT_CLK_RATE 100000000UL
> #define MAX_PAYLOAD_SIZE 256
> #define MAX_READ_REQ_SIZE 256
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] PCI: meson: Drop unused WAIT_LINKUP_TIMEOUT macro
2026-01-05 12:56 [PATCH] PCI: meson: Drop unused WAIT_LINKUP_TIMEOUT macro Martin Blumenstingl
2026-01-05 13:48 ` neil.armstrong
@ 2026-01-05 17:26 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Helgaas @ 2026-01-05 17:26 UTC (permalink / raw)
To: Martin Blumenstingl
Cc: linux-amlogic, linux-pci, linux-kernel, linux-arm-kernel,
bhelgaas, robh, mani, kwilczynski, lpieralisi, yue.wang
On Mon, Jan 05, 2026 at 01:56:25PM +0100, Martin Blumenstingl wrote:
> Commit 113d9712f63b ("PCI: meson: Report that link is up while in ASPM
> L0s and L1 states") removed the waiting loop in meson_pcie_link_up()
> making #define WAIT_LINKUP_TIMEOUT now unused.
>
> Drop the now unused variable to keep the driver code clean.
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Squashed into 113d9712f63b (which is now on for-linus for v6.19),
thanks!
> ---
> drivers/pci/controller/dwc/pci-meson.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/controller/dwc/pci-meson.c b/drivers/pci/controller/dwc/pci-meson.c
> index a1c389216362..0694084f612b 100644
> --- a/drivers/pci/controller/dwc/pci-meson.c
> +++ b/drivers/pci/controller/dwc/pci-meson.c
> @@ -37,7 +37,6 @@
> #define PCIE_CFG_STATUS17 0x44
> #define PM_CURRENT_STATE(x) (((x) >> 7) & 0x1)
>
> -#define WAIT_LINKUP_TIMEOUT 4000
> #define PORT_CLK_RATE 100000000UL
> #define MAX_PAYLOAD_SIZE 256
> #define MAX_READ_REQ_SIZE 256
> --
> 2.52.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-01-05 17:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-05 12:56 [PATCH] PCI: meson: Drop unused WAIT_LINKUP_TIMEOUT macro Martin Blumenstingl
2026-01-05 13:48 ` neil.armstrong
2026-01-05 17:26 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox