Re: [PATCH] PCI: meson: Drop unused WAIT_LINKUP_TIMEOUT macro

neil.armstrong
2026-01-05T13:48:22Z

On 1/5/26 13:56, Martin Blumenstingl wrote:
> Commit 113d9712f63b ("PCI: meson: Report that link is up while in ASPM
> L0s and L1 states") removed the waiting loop in meson_pcie_link_up()
> making #define WAIT_LINKUP_TIMEOUT now unused.
>
> Drop the now unused variable to keep the driver code clean.
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> drivers/pci/controller/dwc/pci-meson.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/controller/dwc/pci-meson.c b/drivers/pci/controller/dwc/pci-meson.c
> index a1c389216362..0694084f612b 100644
> --- a/drivers/pci/controller/dwc/pci-meson.c
> +++ b/drivers/pci/controller/dwc/pci-meson.c
> @@ -37,7 +37,6 @@
> #define PCIE_CFG_STATUS17 0x44
> #define PM_CURRENT_STATE(x) (((x) >> 7) & 0x1)
>
> -#define WAIT_LINKUP_TIMEOUT 4000
> #define PORT_CLK_RATE 100000000UL
> #define MAX_PAYLOAD_SIZE 256
> #define MAX_READ_REQ_SIZE 256

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>