public inbox for linux-pci@vger.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Alex Williamson <alex.williamson@nvidia.com>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
	linux-kernel@vger.kernel.org, alex@shazbot.org,
	Patrick Bianchi <patrick.w.bianchi@gmail.com>
Subject: Re: [PATCH] PCI: Disable bus reset for ASM1164 SATA controller
Date: Fri, 9 Jan 2026 10:28:45 -0600	[thread overview]
Message-ID: <20260109162845.GA548877@bhelgaas> (raw)
In-Reply-To: <20260109000211.398300-1-alex.williamson@nvidia.com>

On Thu, Jan 08, 2026 at 05:02:08PM -0700, Alex Williamson wrote:
> User forums report issues when assigning ASM1164 SATA controllers to
> VMs, especially in configurations with multiple controllers.  Logs
> show the device fails to retrain after bus reset.  Reports suggest
> this is an issue across multiple platforms.  The device indicates
> support for PM reset, therefore the device still has a viable function
> level reset mechanism.  The reporting user confirms the device is well
> behaved in this use case with bus reset disabled.
> 
> Reported-by: Patrick Bianchi <patrick.w.bianchi@gmail.com>
> Link: https://forum.proxmox.com/threads/problems-with-pcie-passthrough-with-two-identical-devices.149003/
> Signed-off-by: Alex Williamson <alex.williamson@nvidia.com>

Applied to pci/virtualization for v6.20, thanks!

> ---
>  drivers/pci/quirks.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index b9c252aa6fe0..3a8d5622ee2b 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -3791,6 +3791,16 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_CAVIUM, 0xa100, quirk_no_bus_reset);
>   */
>  DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_TI, 0xb005, quirk_no_bus_reset);
>  
> +/*
> + * Reports from users making use of PCI device assignment with ASM1164
> + * controllers indicate an issue with bus reset where the device fails to
> + * retrain.  The issue appears more common in configurations with multiple
> + * controllers.  The device does indicate PM reset support (NoSoftRst-),
> + * therefore this still leaves a viable reset method.
> + * https://forum.proxmox.com/threads/problems-with-pcie-passthrough-with-two-identical-devices.149003/
> + */
> +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_ASMEDIA, 0x1164, quirk_no_bus_reset);
> +
>  static void quirk_no_pm_reset(struct pci_dev *dev)
>  {
>  	/*
> -- 
> 2.51.0
> 

      reply	other threads:[~2026-01-09 16:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-09  0:02 [PATCH] PCI: Disable bus reset for ASM1164 SATA controller Alex Williamson
2026-01-09 16:28 ` Bjorn Helgaas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260109162845.GA548877@bhelgaas \
    --to=helgaas@kernel.org \
    --cc=alex.williamson@nvidia.com \
    --cc=alex@shazbot.org \
    --cc=bhelgaas@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=patrick.w.bianchi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox