From: Bjorn Helgaas <helgaas@kernel.org>
To: huyuye <huyuye812@163.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>, Sunil V L <sunilvl@ventanamicro.com>,
Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
Robert Moore <robert.moore@intel.com>,
linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-riscv@lists.infradead.org, acpica-devel@lists.linux.dev,
linux-kernel@vger.kernel.org, dai.hualiang@zte.com.cn,
deng.weixian@zte.com.cn, guo.chang2@zte.com.cn,
liu.qingtao2@zte.com.cn, wu.jiabao@zte.com.cn,
lin.yongchun@zte.com.cn, hu.yuye@zte.com.cn,
zhang.longxiang@zte.com.cn, zuo.jiang@zte.com.cn,
li.kunpeng@zte.com.cn
Subject: Re: [PATCH v2] ACPI: pci_root: Clear the acpi dependencies after PCI root bridge initialization on RISC-V
Date: Tue, 13 Jan 2026 15:56:03 -0600 [thread overview]
Message-ID: <20260113215603.GA781891@bhelgaas> (raw)
In-Reply-To: <20260112141630.2869-1-huyuye812@163.com>
On Mon, Jan 12, 2026 at 10:16:29PM +0800, huyuye wrote:
> Hi Rafael,
> Thank you for your thorough review and valuable comments on v1.
> I've updated the patch as follows:
> 1. Removed the redundant #ifdef CONFIG_ACPI and if (!acpi_disabled)
> guard as you pointed out. The entire code block indeed already depends
> on CONFIG_ACPI at a higher level, making the inner guard unnecessary.
> 2. Moved acpi_dev_clear_dependencies to RISC-V specific architecture
> code (driver/acpi/riscv/acpi_pci.c). This ensures that ACPI dependency
> clearing is handled within the appropriate architectural context.
>
> Best regards
This really should have the commit log here, as it did in the original
post [1].
> Signed-off-by: huyuye <huyuye812@163.com>
> ---
And the description of the changes from v1 to v2 can go here, after
the "---" since it doesn't need to be part of the permanent git
history; see [2].
[1] https://lore.kernel.org/r/20251203140716.3065-1-huyuye812@163.com
[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=v6.18#n784
next prev parent reply other threads:[~2026-01-13 21:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-03 14:07 [PATCH] ACPI: pci_root: Clear the acpi dependencies after PCI root bridge initialization on RISC-V huyuye
2026-01-08 14:04 ` Rafael J. Wysocki
2026-01-12 14:16 ` [PATCH v2] " huyuye
2026-01-13 21:56 ` Bjorn Helgaas [this message]
2026-01-14 12:32 ` [PATCH v3] " huyuye
2026-01-29 14:42 ` [PATCH v4] " huyuye
2026-01-27 15:00 ` [PATCH v2] " Rafael J. Wysocki
2026-01-27 17:25 ` Bjorn Helgaas
2026-01-27 17:50 ` Rafael J. Wysocki
2026-01-27 19:46 ` Bjorn Helgaas
2026-01-27 20:04 ` Rafael J. Wysocki
2026-01-29 13:49 ` Sunil V L
2026-02-19 15:47 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260113215603.GA781891@bhelgaas \
--to=helgaas@kernel.org \
--cc=acpica-devel@lists.linux.dev \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=bhelgaas@google.com \
--cc=dai.hualiang@zte.com.cn \
--cc=deng.weixian@zte.com.cn \
--cc=guo.chang2@zte.com.cn \
--cc=hu.yuye@zte.com.cn \
--cc=huyuye812@163.com \
--cc=lenb@kernel.org \
--cc=li.kunpeng@zte.com.cn \
--cc=lin.yongchun@zte.com.cn \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=liu.qingtao2@zte.com.cn \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=rafael@kernel.org \
--cc=robert.moore@intel.com \
--cc=sunilvl@ventanamicro.com \
--cc=wu.jiabao@zte.com.cn \
--cc=zhang.longxiang@zte.com.cn \
--cc=zuo.jiang@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox