From: Bjorn Helgaas <helgaas@kernel.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: "Brian Norris" <briannorris@chromium.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Lukas Wunner" <lukas@wunner.de>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
linux-pm@vger.kernel.org,
"Rafael J . Wysocki" <rafael@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: Re: [PATCH v4] PCI/PM: Prevent runtime suspend before devices are fully initialized
Date: Wed, 14 Jan 2026 10:45:38 -0600 [thread overview]
Message-ID: <20260114164538.GA816227@bhelgaas> (raw)
In-Reply-To: <0e35a4e1-894a-47c1-9528-fc5ffbafd9e2@samsung.com>
On Wed, Jan 14, 2026 at 10:46:41AM +0100, Marek Szyprowski wrote:
> On 06.01.2026 23:27, Bjorn Helgaas wrote:
> > On Thu, Oct 23, 2025 at 02:09:01PM -0700, Brian Norris wrote:
> >> Today, it's possible for a PCI device to be created and
> >> runtime-suspended before it is fully initialized. When that happens, the
> >> device will remain in D0, but the suspend process may save an
> >> intermediate version of that device's state -- for example, without
> >> appropriate BAR configuration. When the device later resumes, we'll
> >> restore invalid PCI state and the device may not function.
> ...
> > Link: https://patch.msgid.link/20251023140901.v4.1.I60a53c170a8596661883bd2b4ef475155c7aa72b@changeid
>
> This patch landed recently in linux-next as commit c796513dc54e
> ("PCI/PM: Prevent runtime suspend until devices are fully initialized").
> In my tests I found that it sometimes causes the "pci 0000:01:00.0:
> runtime PM trying to activate child device 0000:01:00.0 but parent
> (0000:00:00.0) is not active" warning on Qualcomm Robotics RB5 board
> (arch/arm64/boot/dts/qcom/qrb5165-rb5.dts). This in turn causes a
> lockdep warning about console lock, but this is just a consequence of
> the runtime pm warning. Reverting $subject patch on top of current
> linux-next hides this warning.
I moved this patch from pci/pm to pci/pend to remove it from
linux-next while we figure this out. Thanks for the report and
debugging!
Bjorn
next prev parent reply other threads:[~2026-01-14 16:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-23 21:09 [PATCH v4] PCI/PM: Prevent runtime suspend before devices are fully initialized Brian Norris
2025-11-25 16:14 ` Brian Norris
2026-01-06 22:27 ` Bjorn Helgaas
2026-01-14 9:46 ` Marek Szyprowski
2026-01-14 16:45 ` Bjorn Helgaas [this message]
2026-01-14 20:10 ` Brian Norris
2026-01-15 11:14 ` Marek Szyprowski
2026-01-17 1:19 ` Brian Norris
2026-01-18 11:53 ` Rafael J. Wysocki
2026-01-18 11:59 ` Rafael J. Wysocki
2026-01-19 10:00 ` Marek Szyprowski
2026-01-19 12:26 ` Rafael J. Wysocki
2026-01-19 13:13 ` Marek Szyprowski
2026-01-19 16:10 ` Rafael J. Wysocki
2026-01-22 17:49 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260114164538.GA816227@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=briannorris@chromium.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=m.szyprowski@samsung.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox