From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68E5624BBE4; Wed, 14 Jan 2026 19:45:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768419948; cv=none; b=UWkDSb6P0VVKTWH2Xu9cTmfIwJm6QvUDTHYiJeZ7ISjVRB1k44nEA7ouNIPz/dc+3lPDP+5UilGFMINtJih2qh3z02I0R6nzp8d1mIXiuYsolIjd+Wj3rAFo7eUMLGrTHzGkWUSvr1OGl7Qq+ZuN0LFR6TpYJmbk6pQ+2O6uriQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768419948; c=relaxed/simple; bh=0wat01BJBJNuyYgouu5Vj5+AAODIXrNZPbjZK8RzOLA=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=fSS9QOEqlXH+SRk1IJOJ8J6otXOzEwfKChTJgQnbmZvin+BF/N3C72VymeIG3ZfftWg5IYQpzaICGZ43rDD1dCI+vANarR2lPHXw/M1c5Ly7GOE1t7U/+L53gD/G0TiJtKLKcdfXtQUWnXUWSbL+Ecdm5MgMUVR3jV4gveNcRkA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.224.150]) by frasgout.his.huawei.com (SkyGuard) with ESMTPS id 4drxRW2tZLzJ467W; Thu, 15 Jan 2026 03:45:27 +0800 (CST) Received: from dubpeml100005.china.huawei.com (unknown [7.214.146.113]) by mail.maildlp.com (Postfix) with ESMTPS id 8251440563; Thu, 15 Jan 2026 03:45:42 +0800 (CST) Received: from localhost (10.203.177.15) by dubpeml100005.china.huawei.com (7.214.146.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.36; Wed, 14 Jan 2026 19:45:41 +0000 Date: Wed, 14 Jan 2026 19:45:39 +0000 From: Jonathan Cameron To: Terry Bowman CC: , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v14 14/34] PCI/AER: Report CXL or PCIe bus type in AER trace logging Message-ID: <20260114194539.0000662b@huawei.com> In-Reply-To: <20260114182055.46029-15-terry.bowman@amd.com> References: <20260114182055.46029-1-terry.bowman@amd.com> <20260114182055.46029-15-terry.bowman@amd.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml100010.china.huawei.com (7.191.174.197) To dubpeml100005.china.huawei.com (7.214.146.113) On Wed, 14 Jan 2026 12:20:35 -0600 Terry Bowman wrote: > The AER service driver and aer_event tracing currently log 'PCIe Bus Type' > for all errors. Update the driver and aer_event tracing to log 'CXL Bus > Type' for CXL device errors. > > This requires that AER can identify and distinguish between PCIe errors and > CXL errors. > > Introduce boolean 'is_cxl' to 'struct aer_err_info'. Add assignment in > aer_get_device_error_info() and pci_print_aer(). > > Update the aer_event trace routine to accept a bus type string parameter. > > Signed-off-by: Terry Bowman > Co-developed-by: Dan Williams > Signed-off-by: Dan Williams > Acked-by: Bjorn Helgaas I wonder if it is worth using __print_symbolic() etc and an integer storage rather than a string for in the tracepoints. However, not really that important to me as the strings are small anyway and there is no precedence of this in ras trace events. Reviewed-by: Jonathan Cameron