Re: [PATCH] pci: make reset_subordinate hotplug safe

[kernel test robot <lkp@intel.com>]

Hi Keith,

kernel test robot noticed the following build warnings:

[auto build test WARNING on pci/next]
[also build test WARNING on pci/for-linus linus/master v6.19-rc5 next-20260115]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Keith-Busch/pci-make-reset_subordinate-hotplug-safe/20260115-030004
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next
patch link:    https://lore.kernel.org/r/20260114185821.704089-1-kbusch%40meta.com
patch subject: [PATCH] pci: make reset_subordinate hotplug safe
config: loongarch-allnoconfig (https://download.01.org/0day-ci/archive/20260115/202601151946.zSD1T6Tn-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 9b8addffa70cee5b2acc5454712d9cf78ce45710)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260115/202601151946.zSD1T6Tn-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601151946.zSD1T6Tn-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/pci/pci.c:5585:5: warning: no previous prototype for function '__pci_reset_bus' [-Wmissing-prototypes]
    5585 | int __pci_reset_bus(struct pci_bus *bus)
         |     ^
   drivers/pci/pci.c:5585:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
    5585 | int __pci_reset_bus(struct pci_bus *bus)
         | ^
         | static 
   1 warning generated.


vim +/__pci_reset_bus +5585 drivers/pci/pci.c

9a3d2b9beefd5b0 Alex Williamson 2013-08-14  5578  
090a3c5322e900f Alex Williamson 2013-08-08  5579  /**
c6a44ba950d147e Sinan Kaya      2018-07-19  5580   * __pci_reset_bus - Try to reset a PCI bus
090a3c5322e900f Alex Williamson 2013-08-08  5581   * @bus: top level PCI bus to reset
090a3c5322e900f Alex Williamson 2013-08-08  5582   *
61cf16d8bd38c3d Alex Williamson 2013-12-16  5583   * Same as above except return -EAGAIN if the bus cannot be locked
090a3c5322e900f Alex Williamson 2013-08-08  5584   */
2fa046449a82a7d Keith Busch     2024-10-25 @5585  int __pci_reset_bus(struct pci_bus *bus)
090a3c5322e900f Alex Williamson 2013-08-08  5586  {
090a3c5322e900f Alex Williamson 2013-08-08  5587  	int rc;
090a3c5322e900f Alex Williamson 2013-08-08  5588  
9bdc81ce440ec6e Amey Narkhede   2021-08-17  5589  	rc = pci_bus_reset(bus, PCI_RESET_PROBE);
090a3c5322e900f Alex Williamson 2013-08-08  5590  	if (rc)
090a3c5322e900f Alex Williamson 2013-08-08  5591  		return rc;
090a3c5322e900f Alex Williamson 2013-08-08  5592  
61cf16d8bd38c3d Alex Williamson 2013-12-16  5593  	if (pci_bus_trylock(bus)) {
ddefc033eecf23f Alex Williamson 2019-02-18  5594  		pci_bus_save_and_disable_locked(bus);
61cf16d8bd38c3d Alex Williamson 2013-12-16  5595  		might_sleep();
381634cad15b711 Sinan Kaya      2018-07-19  5596  		rc = pci_bridge_secondary_bus_reset(bus->self);
ddefc033eecf23f Alex Williamson 2019-02-18  5597  		pci_bus_restore_locked(bus);
61cf16d8bd38c3d Alex Williamson 2013-12-16  5598  		pci_bus_unlock(bus);
61cf16d8bd38c3d Alex Williamson 2013-12-16  5599  	} else
61cf16d8bd38c3d Alex Williamson 2013-12-16  5600  		rc = -EAGAIN;
090a3c5322e900f Alex Williamson 2013-08-08  5601  
090a3c5322e900f Alex Williamson 2013-08-08  5602  	return rc;
090a3c5322e900f Alex Williamson 2013-08-08  5603  }
8dd7f8036c12329 Sheng Yang      2008-10-21  5604  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki