From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87E5D32B98F for ; Thu, 22 Jan 2026 14:56:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769093761; cv=none; b=H0qC9G1ekKc39BeoRukLniwrXk+/HpS1WLl8izwB3tfmwdjPiLalMXDKdy5FFOMmowJteCuqV3pxBsiXMSXeHV2ls8TKL0mJexF9uC4AQW1zQYcY2v1j0A65UafonZ63A7RI7o0EWEs0SmnUFOWTCIxG3yrgL0M52AC8GdsT8ZI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769093761; c=relaxed/simple; bh=cZksPCaAMRG2gr0HCRf0xzM01/E+12gbMX0q5TbwHd8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YF5XcmoK/hcYJFZ06a+mKTZ8QsacknppZlc7nPPDSCrHzM4uFhSLky5W7tQPn0oMtewRgNMIfc000dCWpnnHpyuYdjjiY85ByScGPpj8lRsYvGTBSo9SsNKDOutzOfTnvYb33DmJRmBiDt5SuvkCSSveV5vsYHiOLY09cg5fYkU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DH9kB2dx; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DH9kB2dx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 55606C116C6; Thu, 22 Jan 2026 14:55:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769093761; bh=cZksPCaAMRG2gr0HCRf0xzM01/E+12gbMX0q5TbwHd8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DH9kB2dxApJirqrhL4kLVr3BYIHqhf3ZR2D+7UeBpYl8I9kGJglg6gkC0GElnR+PL nUNpWYyVZkYA/IkedgbMK/OfYO4vQJedNUObrxUv9tDY2S+fu+zfdVt99AAjcpu0RO z57dyuPsrgu1winfO295Gpho9kRWhmdVxas0OoDBnWVUNzbgqrZ3Qi3UkhlY5xYUsM y0HyGPsCCF/wufnSrNARLSQB0EUOqX3Bz+8OFSx9IUvjJmxVSk1afVnDzAX5pCIpZH 9OJgfeFTlb3o33SfnH2KGocwbBsfdvtq+7bdEcBqZJSttM8HfTDzZm+jQRO0LYSJGG pGXLqoXeYbs+w== From: Niklas Cassel To: Jingoo Han , Manivannan Sadhasivam , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Frank Li Cc: Randolph Lin , Samuel Holland , Charles Mirabile , tim609@andestech.com, Krishna Chaitanya Chundru , Niklas Cassel , linux-pci@vger.kernel.org Subject: [PATCH 2/3] PCI: dwc: Improve msg_atu_index error handling Date: Thu, 22 Jan 2026 15:54:13 +0100 Message-ID: <20260122145411.453291-5-cassel@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260122145411.453291-4-cassel@kernel.org> References: <20260122145411.453291-4-cassel@kernel.org> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1303; i=cassel@kernel.org; h=from:subject; bh=cZksPCaAMRG2gr0HCRf0xzM01/E+12gbMX0q5TbwHd8=; b=owGbwMvMwCV2MsVw8cxjvkWMp9WSGDKLrIQlhHp7F/++zjxP3KHspFbrkrO5slwzgrae2/b2F dOFDSKBHaUsDGJcDLJiiiy+P1z2F3e7TzmueMcGZg4rE8gQBi5OAZgI5xmG/wU3vzKlTZq1YM0j LhG38JmhDMcT6uadM53rw8Zz6+LtVkaG/wFS78ztu59OvJ685N4UFgetlz8lTxQ87JQV+FpnXFL pywcA X-Developer-Key: i=cassel@kernel.org; a=openpgp; fpr=5ADE635C0E631CBBD5BE065A352FE6582ED9B5DA Content-Transfer-Encoding: 8bit Only try to dedicate an outbound iATU to MSG TLP if use_atu_msg is set. If use_atu_msg is not set, it is completely useless to bump the index. Additionally, if use_atu_msg is set, and there is no available outbound iatu available, return an error. Fixes: e1a4ec1a9520 ("PCI: dwc: Add generic MSG TLP support for sending PME_Turn_Off when system suspend") Signed-off-by: Niklas Cassel --- drivers/pci/controller/dwc/pcie-designware-host.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c index cca5fc886409..991fe5b9a7b3 100644 --- a/drivers/pci/controller/dwc/pcie-designware-host.c +++ b/drivers/pci/controller/dwc/pcie-designware-host.c @@ -982,7 +982,14 @@ static int dw_pcie_iatu_setup(struct dw_pcie_rp *pp) dev_warn(pci->dev, "Ranges exceed outbound iATU size (%d)\n", pci->num_ob_windows); - pp->msg_atu_index = ++i; + if (pp->use_atu_msg) { + if (pci->num_ob_windows > ++i) { + pp->msg_atu_index = i; + } else { + dev_err(pci->dev, "Cannot add outbound window for MSG TLP\n"); + return -ENOMEM; + } + } i = 0; resource_list_for_each_entry(entry, &pp->bridge->dma_ranges) { -- 2.52.0