From: Bjorn Helgaas <helgaas@kernel.org>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
linux-pci@vger.kernel.org,
"Christian König" <christian.koenig@amd.com>,
LKML <linux-kernel@vger.kernel.org>,
stable@vger.kernel.org
Subject: Re: [PATCH 1/2] PCI: Fix BAR resize rollback path overwriting ret
Date: Thu, 22 Jan 2026 10:30:23 -0600 [thread overview]
Message-ID: <20260122163023.GA1251597@bhelgaas> (raw)
In-Reply-To: <dd05361e-39a2-b8f4-d30a-38ce96799982@linux.intel.com>
On Thu, Jan 22, 2026 at 12:07:40PM +0200, Ilpo Järvinen wrote:
> On Wed, 21 Jan 2026, Ilpo Järvinen wrote:
>
> > The commit 337b1b566db0 ("PCI: Fix restoring BARs on BAR resize
> > rollback path") added BAR rollback to
> > pci_do_resource_release_and_resize() in case of resize failure.
> >
> > On the rollback, pci_claim_resource() is called which can fail and the
> > code is prepared for that possibility. pci_claim_resource()'s return
> > value, however, overwrites the original value of ret so
> > pci_claim_resource() will return incorrect value in the end (as
>
> Hi Bjorn,
>
> I noticed this should have been:
>
> "pci_do_resource_release_and_resize() will return incorrect value in the
> end ..."
>
> (used a wrong function name).
>
> Could you please adjust the commit message in your tree if it's not too
> late yet?
Updated, thanks!
next prev parent reply other threads:[~2026-01-22 16:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-21 13:14 [PATCH 0/2] PCI: BAR resize rollback fixes Ilpo Järvinen
2026-01-21 13:14 ` [PATCH 1/2] PCI: Fix BAR resize rollback path overwriting ret Ilpo Järvinen
2026-01-22 10:07 ` Ilpo Järvinen
2026-01-22 16:30 ` Bjorn Helgaas [this message]
2026-01-21 13:14 ` [PATCH 2/2] PCI: Fix Resizable BAR restore order Ilpo Järvinen
2026-01-21 15:52 ` [PATCH 0/2] PCI: BAR resize rollback fixes Ville Syrjälä
2026-01-21 17:46 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260122163023.GA1251597@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=christian.koenig@amd.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox