Re: [PATCH v2 1/2] rust: introduce abstractions for fwctl

Joel Fernandes
2026-01-22T21:18:04Z

On Thu, Jan 22, 2026 at 10:42:30PM +0200, Zhi Wang wrote:
> + /// Called when a userspace RPC request is received.
> + fn fw_rpc(
> + uctx: &mut UserCtx<Self::UserCtx>,
> + scope: u32,
> + rpc_in: &mut [u8],
> + out_len: *mut usize,
> + ) -> Result<Option<KVec<u8>>, Error>;

Exposing a raw pointer in the trait API means drivers that want to "reuse input
buffer" need to write unsafe code right?

unsafe { *out_len = ... };

I believe the unsafe code should be confined to the abstraction layer instead,
not in the driver.

How about using using an enum return type instead to properly wrap inplace
versus driver allocated outputs?

pub enum RpcOutput {
Allocated(KVec<u8>),
InPlace(usize),
}

fn fw_rpc(
uctx: &mut UserCtx<Self::UserCtx>,
scope: u32,
rpc_in: &mut [u8],
) -> Result<RpcOutput, Error>;

Then the abstraction handles the pointer write:

match T::fw_rpc(ctx, scope, rpc_in_slice) {
Ok(RpcOutput::Allocated(kvec)) => {
...
}
Ok(RpcOutput::InPlace(len)) => {
unsafe { *out_len = len };
...
}
}

fw_rpc() as a bonus also gets 1 less function parameter and cleaner return
signature.

--
Joel Fernandes