From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E5DC2566D3; Tue, 27 Jan 2026 22:39:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769553578; cv=none; b=nH7jYOjpJBj0BtsT+GKgUVW5Rp3u55UNn+DMJ1zz7XEApsM/4rNYAplmoctk+KIgvg4Ai2wkvvaw9gWEsq5KnPVEhg1RIc04sakw739Re6ksZK//QkA/q5TZkqClzCYdpniHapCSTIby/ggsiESqwqxQKxaQk6979fscjaxsOdI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769553578; c=relaxed/simple; bh=vAKGXi5/xv7/iqoFOU9jUpxzNmiM/3g3ieVqB/OwEa0=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=TUppYKrbjOCGWb3eX5FR5fcywZgrg88CGOqEuX70eY5O5+qZFjBYr+fsB99MteS4LvmVvpNWrDsNJWp75gTIJPpKTjQ7D6mEesfA8RdZRE7aYPEVKufBY7IN/as8PCQq3gF7jYzMPtN9kyicwwxhhsQN0hgiRb2unPt/4kWaDxc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FoVO8MSg; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FoVO8MSg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1AB37C116C6; Tue, 27 Jan 2026 22:39:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769553578; bh=vAKGXi5/xv7/iqoFOU9jUpxzNmiM/3g3ieVqB/OwEa0=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=FoVO8MSgRtWBjpFwVkIoBs/XdmtkFtcYqTapvPYeUl/4q0Ytd402KQzmGFYFB2soB fh3cXFsEVQ9UCCAUuZZI6u36OwuRn4ncCSg8TJB1JYzafBqPPCK/gUcdSkJKtHMHF4 98Kor5SUQB/AcfKWWHNBwcbo8ripvA29K6ldTR1Ib4RQjI7LGSsRQ9DrUSWzUByx3D Z7yejHKtepwmR7o39+Js+QHE/sWy3Ihvt/DhQ4Hxr8zkdge2edMyZIh3w4AOe6dXWb mxcqUgT46OIIdRbGV+5JwK3Y73t972sro7QrM02jYJ3rbupgO2SXUcy7jG7i0mL7e2 OJcDa3ywisH8w== Date: Tue, 27 Jan 2026 16:39:37 -0600 From: Bjorn Helgaas To: Ilpo =?utf-8?B?SsOkcnZpbmVu?= Cc: linux-pci@vger.kernel.org, Bjorn Helgaas , Dominik Brodowski , LKML , Malte =?utf-8?B?U2NocsO2ZGVy?= , stable@vger.kernel.org Subject: Re: [PATCH 02/23] PCI: Rewrite bridge window head alignment function Message-ID: <20260127223937.GA384008@bhelgaas> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6405c825-6d8e-043c-38f1-e7e1a4ebf44a@linux.intel.com> On Tue, Jan 27, 2026 at 01:22:22PM +0200, Ilpo Järvinen wrote: > On Mon, 26 Jan 2026, Bjorn Helgaas wrote: > > On Fri, Dec 19, 2025 at 07:40:15PM +0200, Ilpo Järvinen wrote: > > > The calculation of bridge window head alignment is done by > > > calculate_mem_align() [*]. With the default bridge window alignment, it > > > is used for both head and tail alignment. > ... > > > Fixes: 5d0a8965aea9 ("[PATCH] 2.5.14: New PCI allocation code (alpha, arm, parisc) [2/2]") > > > > check_commits complains that this SHA1 doesn't exist: > > > > In commit > > > > a21a27a0e893 ("PCI: Rewrite bridge window head alignment function") > > > > Fixes tag > > > > Fixes: 5d0a8965aea9 ("[PATCH] 2.5.14: New PCI allocation code (alpha, arm, parisc) [2/2]") > > > > has these problem(s): > > > > - Target SHA1 does not exist > > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5d0a8965aea9 > > does find it, but says it's not reachable. > > > > It's so old (2002) that I'm not sure it's worth including it as a > > Fixes: tag. > > Hi, > > The commit is in the history repo, and yes, even the git web ui for some > reason says it's not reachable by any branch: > > https://git.kernel.org/pub/scm/linux/kernel/git/history/history.git/commit/?id=5d0a8965aea93bd799ebcd671e562d90f3ec2711 > > ...But it's part of a tag for sure: > > $ git describe --contains 5d0a8965aea93bd799ebcd671e562d90f3ec2711 > v2.5.15~11^2~5^2~10 Thanks, I made it a Link tag instead: Link: https://git.kernel.org/history/history/c/5d0a8965aea9 ("[PATCH] 2.5.14: New PCI allocation code (alpha, arm, parisc) [2/2]")