Re: [PATCH 2/2] pci: fix slot reset device locking

[Bjorn Helgaas <helgaas@kernel.org>]

On Wed, Jan 28, 2026 at 01:07:37PM -0800, dan.j.williams@intel.com wrote:
> Ilpo Järvinen wrote:
> > On Wed, 28 Jan 2026, Bjorn Helgaas wrote:
> > > On Fri, Jan 16, 2026 at 10:41:50AM -0800, Keith Busch wrote:
> > > > From: Keith Busch <kbusch@kernel.org>
> > > > 
> > > > Like pci_bus_lock, pci_slot_lock needs to lock the bridge device to
> > > > prevent the warning:
> > > 
> > > I *think* this actually refers to pci_bus_trylock() and
> > > pci_slot_trylock() (not pci_bus_lock() and pci_slot_lock()), since
> > > that's what this patch changes?
> > > 
> > > It's unfortunate that pci_bus_trylock() and pci_slot_trylock() are so
> > > similar but separate.  If there were combined, this kind of issue
> > > where one is fixed but the other isn't wouldn't happen.
> > > 
> > > But what about pci_bus_lock() and pci_slot_lock()?  They are also
> > > almost identical, but pci_bus_lock() locks bus->self while
> > > pci_slot_lock() does not.  Should it?
> > >
> > > All these almost-but-not-quite identical paths make my head hurt ;)
> > 
> > My series does attempt to consolidation them (check the pending patches 
> > from me).
> > 
> > (It doesn't consider this fix patch though but the other one is taken 
> > into account, the series was build on top of it).
> 
> Lore link?

I think it's
https://lore.kernel.org/all/20260116125742.1890-1-ilpo.jarvinen@linux.intel.com/