From: Bjorn Helgaas <helgaas@kernel.org>
To: "Håkon Bugge" <haakon.bugge@oracle.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Niklas Schnelle <schnelle@linux.ibm.com>,
Alex Williamson <alex@shazbot.org>,
Johannes Thumshirn <morbidrsa@gmail.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH v4 0/2] PCI: Init RCB from pci_configure_device and fix program_hpx_type2
Date: Thu, 29 Jan 2026 12:50:35 -0600 [thread overview]
Message-ID: <20260129185035.GA473061@bhelgaas> (raw)
In-Reply-To: <20260129175237.727059-1-haakon.bugge@oracle.com>
On Thu, Jan 29, 2026 at 06:52:31PM +0100, Håkon Bugge wrote:
> This series add the initialization of the Link Control register's RCB
> to pci_configure_rcb() called from pci_configure_device() and also
> cleans up the incorrect program_hpx_type2():
>
> 1. It should only be called when we own the PCIe native hotplug and
> not the AER ownership
> 2. It should only manipulate the AER-bits
>
> In addition, the second commit adds a warning if the _HPX type2
> record attempts to modify the Link Control register.
>
> The programming of the device's RCB is constrained to the device types
> where it is applicable and also skips VFs. If the Root Port's RCB
> cannot be determined, we also skip the programming of the device's
> RCB.
>
> Then, we program the device's RCB according to the Root Port's setting.
>
> Håkon Bugge (2):
> PCI: Initialize RCB from pci_configure_device()
> PCI/ACPI: Restrict program_hpx_type2() to AER bits
>
> drivers/pci/pci-acpi.c | 65 ++++++++++++++++++------------------------
> drivers/pci/pci.h | 3 ++
> drivers/pci/pcie/aer.c | 3 --
> drivers/pci/probe.c | 33 +++++++++++++++++++++
> 4 files changed, 63 insertions(+), 41 deletions(-)
Applied to pci/enumeration for v6.20.
Thanks for your patience and persistence, I think this all looks great!
next prev parent reply other threads:[~2026-01-29 18:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-29 17:52 [PATCH v4 0/2] PCI: Init RCB from pci_configure_device and fix program_hpx_type2 Håkon Bugge
2026-01-29 17:52 ` [PATCH v4 1/2] PCI: Initialize RCB from pci_configure_device() Håkon Bugge
2026-01-29 17:52 ` [PATCH v4 2/2] PCI/ACPI: Restrict program_hpx_type2() to AER bits Håkon Bugge
2026-01-29 18:50 ` Bjorn Helgaas [this message]
2026-01-30 16:54 ` [PATCH v4 0/2] PCI: Init RCB from pci_configure_device and fix program_hpx_type2 Haakon Bugge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260129185035.GA473061@bhelgaas \
--to=helgaas@kernel.org \
--cc=alex@shazbot.org \
--cc=bhelgaas@google.com \
--cc=haakon.bugge@oracle.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=morbidrsa@gmail.com \
--cc=schnelle@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox