Re: [PATCHv2 0/4] pci: slot handling fixes

[Bjorn Helgaas <helgaas@kernel.org>]

On Fri, Jan 30, 2026 at 08:59:49AM -0800, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
> 
> This series fixes some older issues are the slot lock usage, with two
> follow on patches to address multi-function resets in pcie hotplug
> slots.
> 
> Previous discussions:
> 
>   https://lore.kernel.org/linux-pci/20260116184150.3013258-1-kbusch@meta.com/
> 
>   https://lore.kernel.org/linux-pci/aXvOOjZQ_EmZDgVs@kbusch-mbp/T/#t
> 
> Version change notes:
> 
>  * The first patch is unchanged from the original.
> 
>  * The second patch adds the local "bridge" to improve code clarity
>    (review comments from Dan)
> 
>  * The third patch removes pci_slot_resettable in addition to all the
>    other slot specific locking and state saving functions. I also
>    updated a code comment explaining that all bus devices are saved and
>    restored with the slot reset.
> 
>  * Included a fourth patch that fixes user suborindate bus resets when the
>    bridge is pcie hotplug capable; a previous version came from this
>    independent patch here:
> 
>   https://lore.kernel.org/linux-pci/20260116154244.1452246-1-kbusch@meta.com/
> 
>    And I'm including it in this series since it is all in the same area
>    with slot resets. I've made a minor change to the previous version to
>    remove the code duplication with pci_bus_error_reset().
> 
> Jinhui Guo (1):
>   PCI: Fix incorrect unlocking in pci_slot_trylock()
> 
> Keith Busch (3):
>   pci: fix slot reset device locking
>   pci: remove slot specific lock/unlock and save/restore
>   pci: make reset_subordinate hotplug safe
> 
>  drivers/pci/pci-sysfs.c |   3 +-
>  drivers/pci/pci.c       | 213 +++++++++++-----------------------------
>  drivers/pci/pci.h       |   2 +-
>  3 files changed, 61 insertions(+), 157 deletions(-)

Applied the first two on pci/virtualization for now (the first was
already there):

  67bcd817a012 ("PCI: Fix pci_slot_trylock() error handling")
  c6a26e539649 ("PCI: Fix pci_slot_lock () device locking")

If we get a review for the others I'll add them on top.

Thanks!