From: Bjorn Helgaas <helgaas@kernel.org>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Jinhui Guo <guojinhui.liam@bytedance.com>,
Keith Busch <kbusch@kernel.org>,
"Anthony Pighin (Nokia)" <anthony.pighin@nokia.com>,
Alex Williamson <alex@shazbot.org>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] PCI: Locking related improvements
Date: Fri, 6 Feb 2026 16:56:51 -0600 [thread overview]
Message-ID: <20260206225651.GA103421@bhelgaas> (raw)
In-Reply-To: <20260116125742.1890-1-ilpo.jarvinen@linux.intel.com>
On Fri, Jan 16, 2026 at 02:57:39PM +0200, Ilpo Järvinen wrote:
> Hi all,
>
> Here are a few locking related coding quality improvements, none of
> them aims to introduce any function changes. First two convert "must be
> asserted" comments into lockdep asserts for easier detection of
> violations. The last patch consolidates almost duplicated code in the
> bus/slot locking function.
>
> This series based is based on top of the fix (the last change would
> obviously conflict with it):
>
> https://patchwork.kernel.org/project/linux-pci/patch/20251212145528.2555-1-guojinhui.liam@bytedance.com/
>
>
> Ilpo Järvinen (3):
> PCI: Use lockdep_assert_held(pci_bus_sem) to verify lock is held
> PCI: Use device_lock_assert() to verify device lock is held
> PCI: Consolidate pci_bus/slot_lock/unlock/trylock()
>
> drivers/pci/pci.c | 120 ++++++++++++++++++++++++----------------------
> 1 file changed, 63 insertions(+), 57 deletions(-)
Applied the first two to pci/virtualization along with the other reset
changes for v6.20, thanks!
The last is a great idea but will need some rebase/rework on top of
Keith's changes.
prev parent reply other threads:[~2026-02-06 22:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-16 12:57 [PATCH 0/3] PCI: Locking related improvements Ilpo Järvinen
2026-01-16 12:57 ` [PATCH 1/3] PCI: Use lockdep_assert_held(pci_bus_sem) to verify lock is held Ilpo Järvinen
2026-01-16 12:57 ` [PATCH 2/3] PCI: Use device_lock_assert() to verify device " Ilpo Järvinen
2026-01-16 12:57 ` [PATCH 3/3] PCI: Consolidate pci_bus/slot_lock/unlock/trylock() Ilpo Järvinen
2026-01-16 12:59 ` [PATCH 0/3] PCI: Locking related improvements Ilpo Järvinen
2026-02-06 22:56 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260206225651.GA103421@bhelgaas \
--to=helgaas@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=alex@shazbot.org \
--cc=anthony.pighin@nokia.com \
--cc=bhelgaas@google.com \
--cc=guojinhui.liam@bytedance.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox