Re: [PATCH v11 0/2] PCI: Fix crash when access broken ROM

[Bjorn Helgaas <helgaas@kernel.org>]

On Mon, Feb 09, 2026 at 02:43:39PM +0800, Guixin Liu wrote:
> Gentling ping...
> 
> Hi Bjorn and Ilpo, Could you please review these two patches?
> 
> In this version, I fixed the case issues in the first patch title.

Will do, thanks.  Since the v7.0 merge window is open, this is on my
list to look at as soon as v7.0-rc1 is tagged, probably on Feb 22.

> 在 2026/1/30 16:07, Guixin Liu 写道:
> > v10 -> v11:
> > - Change 'pci rom' to 'PCI ROM' of the tittle of the first patch.
> > - Add Andy Shevchenko's rb tag in the first patch, thanks.
> > 
> > v9 -> v10:
> > - Reorder the header files, and not touch kernel.h
> > - Change PCI_ROM_IMAGE_LEN_UNIT_BYTES to PCI_ROM_IMAGE_SECTOR_SIZE.
> > - Add a comment for PCI_ROM_DATA_STRUCT_SIGNATURE.
> > 
> > v8 -> v9:
> > - Supplemental explanation for the commit body of the first patch.
> > - Change PCI_ROM_IMAGE_LEN_UNIT_SZ_512 to PCI_ROM_IMAGE_LEN_UNIT_BYTES,
> > and change it's definition to SZ_512.
> > - Use u16 and u32 for signature val instead of unsigned short/int.
> > 
> > v7 -> v8:
> > - Ordered header files alphabetically.
> > - Convert the literals too in the firt patch.
> > - Use local val to save signature instead of reading twice.
> > 
> > v6 -> v7:
> > - Put all named defines to a separate patch.
> > - Change PCI_ROM_IMAGE_LEN_UNIT_BYTES to PCI_ROM_IMAGE_LEN_UNIT_SZ_512.
> > - Named BIT(7) to PCI_ROM_LAST_IMAGE_INDICATOR_BIT.
> > - Fix all other comments from Ilpo, such as including header files,
> > and alignment fault, Thanks.
> > 
> > v5 -> v6:
> > - Convert some magic number to named defines, suggested by
> > Ilpo, thanks.
> > 
> > v4 -> v5:
> > - Add Andy Shevchenko's rb tag, thanks.
> > - Change u64 to unsigned long.
> > - Change pci_rom_header_valid() to pci_rom_is_header_valid() and
> > change pci_rom_data_struct_valid() to pci_rom_is_data_struct_valid().
> > - Change rom_end from rom+size to rom+size-1 for more readble,
> > and also change header_end >= rom_end to header_end > rom_end, same
> > as data structure end.
> > - Change if(!last_image) to if (last_image)..
> > - Use U16_MAX instead of 0xffff.
> > - Split check_add_overflow() from data_len checking.
> > - Remove !!() when reading last_image, and Use BIT(7) instead of 0x80.
> > 
> > v3 -> v4:
> > - Use "u64" instead of "uintptr_t".
> > - Invert the if statement to avoid excessive indentation.
> > - Add comment for alignment checking.
> > - Change last_image's type from int to bool.
> > 
> > v2 -> v3:
> > - Add pci_rom_header_valid() helper for checking image addr and signature.
> > - Add pci_rom_data_struct_valid() helper for checking data struct add
> > and signature.
> > - Handle overflow issue when adding addr with size.
> > - Handle alignment fault when running on arm64.
> > 
> > v1 -> v2:
> > - Fix commit body problems, such as blank line in "Call Trace" both sides,
> >    thanks, (Andy Shevchenko).
> > - Remove every step checking, just check the addr is in header or data
> > struct.
> > - Add Suggested-by: Guanghui Feng <guanghuifeng@linux.alibaba.com> tag.
> > 
> > Guixin Liu (2):
> >    PCI: Introduce named defines for PCI ROM
> >    PCI: Check ROM header and data structure addr before accessing
> > 
> >   drivers/pci/rom.c | 137 ++++++++++++++++++++++++++++++++++++++--------
> >   1 file changed, 115 insertions(+), 22 deletions(-)
> > 
>