From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f42.google.com (mail-qv1-f42.google.com [209.85.219.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C26E811CAF for ; Thu, 12 Feb 2026 14:17:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770905862; cv=none; b=OetS7YFtzXPk2JJUsKKt2Ue2pIowjr4Ouee3EQSVfGIDJMgeJbcnGqOpEttgXnSwsC/aSN8+6YJLqa/swONMlU0Kp8zyzOXzJoUJxbbg4MZrbruwFP0moEPrHwXfkSHr1J3U1lUX2JJB+mUZKWeBB1vTx+OM0pVMozs6WWXXYoI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770905862; c=relaxed/simple; bh=3b3igbvjtC6TzOflHJmS47zTEL8ymbacN0YsKIuJxWU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KMVkWiTj8N2h6bKGBRzQ/ShHWRkw/w/d5G+QLs6SkvqbaSaWlY6xllJhVe1WEASOfRMQ6ZJR68Unf/GDSU7JNIW2wasavJT0Ss/KggR8LYOF3RXB1EkU+P3izXM8hCXDVkxmmOLVI8uL2MvaHBJh3tlesgL65oBEMjliLv7iAmg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=Q3uRx0oV; arc=none smtp.client-ip=209.85.219.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="Q3uRx0oV" Received: by mail-qv1-f42.google.com with SMTP id 6a1803df08f44-895341058b1so88575556d6.3 for ; Thu, 12 Feb 2026 06:17:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1770905860; x=1771510660; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3b3igbvjtC6TzOflHJmS47zTEL8ymbacN0YsKIuJxWU=; b=Q3uRx0oVkpBtjZMZbSndCvl0/QfZMt7MAbI3D53Txnr5ruSGu9lv2TFV5MAf2viUVP DBTTpZdyOU0CG9x13bvE8QdJ1Ws1qPBvvtbXzd3CGRZ/jPPL8wabZgieEAYpzhRGMF/O YPNOJTeSNw+dkZ/VtglpsW0d50nHTNJyHM+tyGNLHF+MRSikENW+5UT0wSzONaWcbioI 0ySfyGpJ+0eaQEwRJrsNaAljb6ddCr+R4BrrICxJgWeaY8Ja6zeTgfwm7v9Cn/dmSKsy uuMMALbstQPH3dip8zt8iFv9o1DHdy4Mq3g+Srd2i9qde8R7TpaO/L1Q3TtoJxdNPstJ IS9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770905860; x=1771510660; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3b3igbvjtC6TzOflHJmS47zTEL8ymbacN0YsKIuJxWU=; b=wu65h2NcBV0SPWwkV+BfBc3S/To9LUSwBkIWXWB41DXSl630sHpiwqcRpcBpmwlbMV 4XrpO7RRdw5tTD5MvfkVgOzCMQIdxiBI8iWEKMYwmRvGUnWK/V1mWtpig1+JPc1zaFRX M45lcxip1xlTVwZDtoX2/qVEz+lMbDX/qa8XfxnGPzgarRy4H4VMWfqbX7d1Dscmc0QL 5TXtZFGslX0e/f81MmjvBYzmUAX4qWl3ozy7ZiJmTEYEGYhiLN3YoESP0x/YR0C1i3Rf O7C0+X3fT33H/Z6hmyTbwhBYFsqB1IvYYHhaaqlNcwD/wd6HVIRR3QjTnanZRDL1o14+ N5Nw== X-Forwarded-Encrypted: i=1; AJvYcCVRoscTfdFIG7hZZkUsPiz97E+5V7NNiZwGRnNq2fd7cLBhkh7G4L1GBsXga26zzO1s87UUSNkhHRs=@vger.kernel.org X-Gm-Message-State: AOJu0YzTuCaZ8sNOlRl36nBBUF0YbWz8dKzU2tjgSQ8NN3/O6Cu+pQf5 6VxHumBnP8aoBWf/eZ6sMhDBTC1i10lUbEmbCevVi21brmIjnQObdutMoP7iC0TB2UA= X-Gm-Gg: AZuq6aJUuq9z6w5wrOilfu4gPwELWQ4NRmeRa7wDW4Tw2p2uEwXlwIPwj6YShhKJ8+X l/6r8ZMe9dZIieRtbtnQviSiNEkAPxMB/2EJMLkWxjiq5l4mRtfUe9IXfeU49ku3kleZY4uaqFQ 5P0npE6IzHPnSuR/nIArg+DmUqSbRFFmngB6rfEZ0h3anZolZ/xlo3pMs1m1kITzJFjXQBF8mKk eyBMxNGviGws3+n/WLPMpTJDmspglOSWzpcSTUmqv0HXXOWemORDisLwEH3gXxEYWOzYRyJK7C7 O2AgfiH8pKfNzirvtNymINgmNvKF3w4GxjujyXfqwU4OzhwIhRxLZfz9xcZc7s94dUWzH8sMVd+ DoXsfqSi7jub039w0J1MXE2wRl2VW+4qBDs9MvLSxWjx/dcKOGKSdL8oVCp7dSUOjugheg4Dt8o 5ZivW7bMGU2iIqWZPmpvRKuc4IolD4it98ltimAp3/TmhIPDQdMA2zSYweaCkbUuVoW15bQPzFv 8zWqwA= X-Received: by 2002:a05:6214:b6d:b0:888:4939:c29 with SMTP id 6a1803df08f44-89727b28033mr38655036d6.71.1770905859509; Thu, 12 Feb 2026 06:17:39 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-112-119.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.112.119]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8971cddb9efsm45048286d6.51.2026.02.12.06.17.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Feb 2026 06:17:38 -0800 (PST) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1vqXVi-000000013HU-0xrD; Thu, 12 Feb 2026 10:17:38 -0400 Date: Thu, 12 Feb 2026 10:17:38 -0400 From: Jason Gunthorpe To: Julian Ruess Cc: schnelle@linux.ibm.com, wintera@linux.ibm.com, ts@linux.ibm.com, oberpar@linux.ibm.com, gbayer@linux.ibm.com, Alex Williamson , Yishai Hadas , Shameer Kolothum , Kevin Tian , mjrosato@linux.ibm.com, alifm@linux.ibm.com, raspl@linux.ibm.com, hca@linux.ibm.com, agordeev@linux.ibm.com, gor@linux.ibm.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH 1/3] vfio/pci: Set VFIO_PCI_OFFSET_SHIFT to 48 Message-ID: <20260212141738.GM750753@ziepe.ca> References: <20260212-vfio_pci_ism-v1-0-333262ade074@linux.ibm.com> <20260212-vfio_pci_ism-v1-1-333262ade074@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260212-vfio_pci_ism-v1-1-333262ade074@linux.ibm.com> On Thu, Feb 12, 2026 at 03:02:15PM +0100, Julian Ruess wrote: > Extend VFIO_PCI_OFFSET_SHIFT to 48 to use the vfio-pci > VFIO_PCI_OFFSET_TO_INDEX() mechanism with the 256 TiB pseudo-BAR 0 of > the ISM device on s390. This bar is never mapped. Woah, this is dangerous, the size was selected to fit within a pgoff of a 32bit system.. Does this entirely break vfio on 32 bit? Jason