From: kernel test robot <lkp@intel.com>
To: Simon Richter <Simon.Richter@hogyros.de>, linux-pci@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev, intel-xe@lists.freedesktop.org,
dri-devel@lists.freedesktop.org,
Simon Richter <Simon.Richter@hogyros.de>
Subject: Re: [PATCH 3/5] vgaarb: mark vga_get family as __must_check
Date: Wed, 18 Feb 2026 09:51:07 +0800 [thread overview]
Message-ID: <202602180912.N7IZbIal-lkp@intel.com> (raw)
In-Reply-To: <20260217170419.236739-4-Simon.Richter@hogyros.de>
Hi Simon,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 9702969978695d9a699a1f34771580cdbb153b33]
url: https://github.com/intel-lab-lkp/linux/commits/Simon-Richter/vgaarb-pass-vga_get-errors-to-userspace/20260218-010647
base: 9702969978695d9a699a1f34771580cdbb153b33
patch link: https://lore.kernel.org/r/20260217170419.236739-4-Simon.Richter%40hogyros.de
patch subject: [PATCH 3/5] vgaarb: mark vga_get family as __must_check
config: powerpc-randconfig-002-20260218 (https://download.01.org/0day-ci/archive/20260218/202602180912.N7IZbIal-lkp@intel.com/config)
compiler: powerpc-linux-gcc (GCC) 8.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260218/202602180912.N7IZbIal-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202602180912.N7IZbIal-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/gpu/drm/i915/display/intel_vga.c: In function 'intel_vga_disable':
>> drivers/gpu/drm/i915/display/intel_vga.c:68:2: warning: ignoring return value of 'vga_get_uninterruptible', declared with attribute warn_unused_result [-Wunused-result]
vga_get_uninterruptible(pdev, VGA_RSRC_LEGACY_IO);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/display/intel_vga.c: In function 'intel_vga_reset_io_mem':
drivers/gpu/drm/i915/display/intel_vga.c:93:2: warning: ignoring return value of 'vga_get_uninterruptible', declared with attribute warn_unused_result [-Wunused-result]
vga_get_uninterruptible(pdev, VGA_RSRC_LEGACY_IO);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/vga_get_uninterruptible +68 drivers/gpu/drm/i915/display/intel_vga.c
0c80d60ae63461 Ville Syrjälä 2025-04-17 43
4fb8783165b7c6 Jani Nikula 2019-10-01 44 /* Disable the VGA plane that we never use */
4b6e05c43b7542 Ville Syrjälä 2024-09-06 45 void intel_vga_disable(struct intel_display *display)
4fb8783165b7c6 Jani Nikula 2019-10-01 46 {
4b6e05c43b7542 Ville Syrjälä 2024-09-06 47 struct pci_dev *pdev = to_pci_dev(display->drm->dev);
4b6e05c43b7542 Ville Syrjälä 2024-09-06 48 i915_reg_t vga_reg = intel_vga_cntrl_reg(display);
0c80d60ae63461 Ville Syrjälä 2025-04-17 49 enum pipe pipe;
0c80d60ae63461 Ville Syrjälä 2025-04-17 50 u32 tmp;
4fb8783165b7c6 Jani Nikula 2019-10-01 51 u8 sr1;
4fb8783165b7c6 Jani Nikula 2019-10-01 52
0c80d60ae63461 Ville Syrjälä 2025-04-17 53 tmp = intel_de_read(display, vga_reg);
0c80d60ae63461 Ville Syrjälä 2025-04-17 54 if (tmp & VGA_DISP_DISABLE)
a3af0140663dc3 Emil Velikov 2021-06-04 55 return;
a3af0140663dc3 Emil Velikov 2021-06-04 56
0c80d60ae63461 Ville Syrjälä 2025-04-17 57 if (display->platform.cherryview)
0c80d60ae63461 Ville Syrjälä 2025-04-17 58 pipe = REG_FIELD_GET(VGA_PIPE_SEL_MASK_CHV, tmp);
0c80d60ae63461 Ville Syrjälä 2025-04-17 59 else if (has_vga_pipe_sel(display))
0c80d60ae63461 Ville Syrjälä 2025-04-17 60 pipe = REG_FIELD_GET(VGA_PIPE_SEL_MASK, tmp);
0c80d60ae63461 Ville Syrjälä 2025-04-17 61 else
0c80d60ae63461 Ville Syrjälä 2025-04-17 62 pipe = PIPE_A;
0c80d60ae63461 Ville Syrjälä 2025-04-17 63
0c80d60ae63461 Ville Syrjälä 2025-04-17 64 drm_dbg_kms(display->drm, "Disabling VGA plane on pipe %c\n",
0c80d60ae63461 Ville Syrjälä 2025-04-17 65 pipe_name(pipe));
0c80d60ae63461 Ville Syrjälä 2025-04-17 66
4fb8783165b7c6 Jani Nikula 2019-10-01 67 /* WaEnableVGAAccessThroughIOPort:ctg,elk,ilk,snb,ivb,vlv,hsw */
4fb8783165b7c6 Jani Nikula 2019-10-01 @68 vga_get_uninterruptible(pdev, VGA_RSRC_LEGACY_IO);
f0bb41fad02e03 Jani Nikula 2022-02-02 69 outb(0x01, VGA_SEQ_I);
f0bb41fad02e03 Jani Nikula 2022-02-02 70 sr1 = inb(VGA_SEQ_D);
f0bb41fad02e03 Jani Nikula 2022-02-02 71 outb(sr1 | VGA_SR01_SCREEN_OFF, VGA_SEQ_D);
4fb8783165b7c6 Jani Nikula 2019-10-01 72 vga_put(pdev, VGA_RSRC_LEGACY_IO);
4fb8783165b7c6 Jani Nikula 2019-10-01 73 udelay(300);
4fb8783165b7c6 Jani Nikula 2019-10-01 74
4b6e05c43b7542 Ville Syrjälä 2024-09-06 75 intel_de_write(display, vga_reg, VGA_DISP_DISABLE);
4b6e05c43b7542 Ville Syrjälä 2024-09-06 76 intel_de_posting_read(display, vga_reg);
4fb8783165b7c6 Jani Nikula 2019-10-01 77 }
4fb8783165b7c6 Jani Nikula 2019-10-01 78
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2026-02-18 1:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-17 17:04 [PATCH 0/5] bridges without VGA support Simon Richter
2026-02-17 17:04 ` [PATCH 1/5] vgaarb: pass vga_get errors to userspace Simon Richter
2026-02-17 17:04 ` [PATCH 2/5] vgaarb: pass errors from pci_set_vga_state up Simon Richter
2026-02-17 17:04 ` [PATCH 3/5] vgaarb: mark vga_get family as __must_check Simon Richter
2026-02-18 1:51 ` kernel test robot [this message]
2026-02-18 5:59 ` kernel test robot
2026-02-17 17:04 ` [PATCH 4/5] pci: check if VGA decoding was really activated Simon Richter
2026-02-17 17:04 ` [PATCH 5/5] pci: mark return value of pci_set_vga_state as __must_check Simon Richter
2026-02-18 13:46 ` [PATCH v2 0/5] Bridges without VGA support Simon Richter
2026-02-18 13:46 ` [PATCH v2 1/5] vgaarb: pass vga_get errors to userspace Simon Richter
2026-02-18 13:46 ` [PATCH v2 2/5] vgaarb: pass errors from pci_set_vga_state up Simon Richter
2026-02-18 13:46 ` [PATCH v2 3/5] vgaarb: mark vga_get family as __must_check Simon Richter
2026-02-23 0:52 ` kernel test robot
2026-02-18 13:46 ` [PATCH v2 4/5] pci: check if VGA decoding was really activated Simon Richter
2026-02-18 13:46 ` [PATCH v2 5/5] pci: mark return value of pci_set_vga_state as __must_check Simon Richter
2026-02-18 17:51 ` [PATCH v2 0/5] Bridges without VGA support Bjorn Helgaas
2026-02-19 4:06 ` Simon Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202602180912.N7IZbIal-lkp@intel.com \
--to=lkp@intel.com \
--cc=Simon.Richter@hogyros.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=linux-pci@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox