From: Steven Rostedt <rostedt@goodmis.org>
To: Shawn Lin <shawn.lin@rock-chips.com>
Cc: Manivannan Sadhasivam <mani@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-rockchip@lists.infradead.org, linux-pci@vger.kernel.org,
linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
Masami Hiramatsu <mhiramat@kernel.org>
Subject: Re: [PATCH v4 1/3] PCI: trace: Add PCI controller LTSSM transition tracepoint
Date: Tue, 24 Feb 2026 09:08:27 -0500 [thread overview]
Message-ID: <20260224090827.59640d90@fedora> (raw)
In-Reply-To: <1769047340-113287-2-git-send-email-shawn.lin@rock-chips.com>
On Thu, 22 Jan 2026 10:02:18 +0800
Shawn Lin <shawn.lin@rock-chips.com> wrote:
> +bool pci_ltssm_tp_enabled(void)
> +{
> + return atomic_read(&pcie_ltssm_tp_enabled) > 0;
> +}
> +EXPORT_SYMBOL(pci_ltssm_tp_enabled);
> +
> +int pci_ltssm_tp_reg(void)
> +{
> + atomic_inc(&pcie_ltssm_tp_enabled);
> + return 0;
> +}
> +
> +void pci_ltssm_tp_unreg(void)
> +{
> + atomic_dec(&pcie_ltssm_tp_enabled);
> +}
This seems totally unnecessary. Why the atomic operations? Why not just
use:
if (trace_pcie_ltssm_state_transition_enabled()) ...
?
-- Steve
next prev parent reply other threads:[~2026-02-24 14:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-22 2:02 [PATCH v4 0/3] PCI Controller event and LTSSM tracepoint support Shawn Lin
2026-01-22 2:02 ` [PATCH v4 1/3] PCI: trace: Add PCI controller LTSSM transition tracepoint Shawn Lin
2026-02-24 14:08 ` Steven Rostedt [this message]
2026-02-24 15:22 ` Ilpo Järvinen
2026-02-24 15:35 ` Manivannan Sadhasivam
2026-02-24 15:46 ` Ilpo Järvinen
2026-02-26 5:52 ` Manivannan Sadhasivam
2026-01-22 2:02 ` [PATCH v4 2/3] Documentation: tracing: Add PCI controller event documentation Shawn Lin
2026-01-22 2:02 ` [PATCH v4 3/3] PCI: dw-rockchip: Add pcie_ltssm_state_transition trace support Shawn Lin
2026-02-24 14:11 ` Steven Rostedt
2026-02-24 14:16 ` Steven Rostedt
2026-02-25 1:25 ` Shawn Lin
2026-02-26 0:13 ` Steven Rostedt
2026-03-03 3:25 ` Shawn Lin
2026-02-11 13:13 ` [PATCH v4 0/3] PCI Controller event and LTSSM tracepoint support Shawn Lin
2026-02-11 15:40 ` Manivannan Sadhasivam
2026-02-24 8:49 ` Shawn Lin
2026-02-24 14:06 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260224090827.59640d90@fedora \
--to=rostedt@goodmis.org \
--cc=bhelgaas@google.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mhiramat@kernel.org \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox