Re: [Intel-wired-lan] [PATCH 3/5] igc: Don't reset the hardware on suspend path

Dahan, AvigailX
2026-03-09T10:39:33Z

On 24/02/2026 13:10, Mika Westerberg wrote:
> Commit c01163dbd1b8 ("PCI/PM: Always disable PTM for all devices during
> suspend") made the PCI core to suspend (disable) PTM before driver
> suspend hooks are called. In case of igc what happens is that on suspend
> path PCI core calls pci_suspend_ptm() then igc suspend hook that calls
> igc_down() that ends up calling igc_ptp_reset() (which according to the
> comment is actually needed for re-enabling the device). Anyways that
> function also poll IGC_PTM_STAT that will end up timing out because PTM
> is already disabled:
>
> [ 160.716119] igc 0000:03:00.0 enp3s0: Timeout reading IGC_PTM_STAT register
>
> There should be no reason resetting the hardware on suspend path so fix
> this by avoiding the reset.
>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---
> drivers/net/ethernet/intel/igc/igc.h | 2 +-
> drivers/net/ethernet/intel/igc/igc_ethtool.c | 6 +++---
> drivers/net/ethernet/intel/igc/igc_main.c | 13 +++++++------
> 3 files changed, 11 insertions(+), 10 deletions(-)
>

Tested-by: Avigail Dahan <avigailx.dahan@intel.com>