Re: [PATCH] PCI: Change PCIe capability registers offset to hex

[Bjorn Helgaas <helgaas@kernel.org>]

On Fri, Feb 27, 2026 at 09:12:39AM +0000, David Woodhouse wrote:
> > On Thu, Nov 18, 2021 at 04:13:00PM +0200, Baruch Siach wrote:
> > > Hex notation matches the spec documents, and is less error prone.
> > > 
> > > Suggested-by: Bjorn Helgaas <helgaas@kernel.org>
> > > Link: https://lore.kernel.org/r/20210825160516.GA3576414@bjorn-Precision-5520/
> > > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> > 
> > Applied to pci/misc for v5.17, thanks!
> > 
> > I also converted some other capabilities that had offsets > 8.
> ...

> What you committed in fb82437fdd8cd also changes
> PCI_CAP_EXP_ENDPOINT_SIZEOF_V2:
> 
> -#define PCI_CAP_EXP_ENDPOINT_SIZEOF_V2	52	/* v2 endpoints with link end here */
> +#define PCI_CAP_EXP_ENDPOINT_SIZEOF_V2	0x32	/* end of v2 EPs w/ link */
> 
> That's not actually the same number. Was that intentional? If so it
> should have been done in a separate commit...

Ouch.  Unintentional and completely my mistake.  Did you trip over
something, or find it by inspection?  If there's any kind of defect
signature, I'd like to include it in the commit log.

I posted a fix:
https://lore.kernel.org/linux-pci/20260227123653.3891008-1-bhelgaas@google.com/T/#u

and put it on pci/for-linus.  I intend to ask Linus to pull it later
today.

Thank you very much for finding this.

Bjorn