From: Bjorn Helgaas <helgaas@kernel.org>
To: Nilay Shroff <nilay@linux.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org,
sparclinux@vger.kernel.org, wangruikang@iscas.ac.cn,
tglx@kernel.org, maddy@linux.ibm.com, mpe@ellerman.id.au,
npiggin@gmail.com, chleroy@kernel.org, gjoyce@ibm.com,
davem@davemloft.net, andreas@gaisler.com,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
Han Gao <gaohan@iscas.ac.cn>,
Nathaniel Roach <nroach44@nroach44.id.au>,
Venkat <venkat88@linux.ibm.com>, Nam Cao <namcao@linutronix.de>
Subject: Re: [PATCHv2 0/2] pci: fix msi_addr_mask on powerpc and sparc systems
Date: Mon, 2 Mar 2026 17:07:53 -0600 [thread overview]
Message-ID: <20260302230753.GA4034944@bhelgaas> (raw)
In-Reply-To: <20260220070239.1693303-1-nilay@linux.ibm.com>
On Fri, Feb 20, 2026 at 12:32:26PM +0530, Nilay Shroff wrote:
> Hi,
>
> Recent changes [1] which replaced pci_dev::no_64bit_msi with pci_dev::
> msi_addr_mask inadvertently missed to initialize the pci_dev::msi_addr_mask
> to the DMA_BIT_MASK(64) on powerpc platform. Due to this, later the
> validation the programmed MSI address against the msi_addr_mask fails.
> This causes pci device probe method failures on powerpc platform. We also
> realized that similar issue could potentially happen on sparc system as
> well. So this series initializes pci_dev::msi_addr_mask to DMA_BIT_MASK(64)
> when pci_dev is instantiated for both powerpc and sparc platforms.
>
> The first patch in the series fixes this on powerpc platform. The second
> patch fixes this issue on sparc platform. Please note that as I don't have
> access to the sparc platform, this patch was only compile tested on the
> sparc system. Anyone from the community is welcome to test it who has
> access to the sparc machine.
>
> [1] https://lore.kernel.org/all/20260129-pci-msi-addr-mask-v4-0-70da998f2750@iscas.ac.cn/
>
> Changes since v1:
> - Initialize the pci_dev:msi_addr_mask on sparc platform (Vivian Wang)
> - Some minor cosmetic fixes (Bjorn Helgaas)
>
> Nilay Shroff (2):
> powerpc/pci: Initialize msi_addr_mask for OF-created PCI devices
> sparc/pci: Initialize msi_addr_mask for OF-created PCI devices
>
> arch/powerpc/kernel/pci_of_scan.c | 7 +++++++
> arch/sparc/kernel/pci.c | 7 +++++++
> 2 files changed, 14 insertions(+)
I applied both of these to pci/for-linus for v7.0 since they fix
regressions.
Thanks to Han and Nathaniel for testing on sparc and Venkat and Nam
for testing on powerpc.
Let me know if you have issues with these or prefer to merge via
another tree; I'll be happy to drop.
Bjorn
prev parent reply other threads:[~2026-03-02 23:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-20 7:02 [PATCHv2 0/2] pci: fix msi_addr_mask on powerpc and sparc systems Nilay Shroff
2026-02-20 7:02 ` [PATCHv2 1/2] powerpc/pci: Initialize msi_addr_mask for OF-created PCI devices Nilay Shroff
2026-02-22 10:46 ` Venkat
2026-03-01 6:59 ` Nam Cao
2026-02-20 7:02 ` [PATCHv2 2/2] sparc/pci: " Nilay Shroff
2026-02-21 16:36 ` Han Gao
2026-02-22 6:01 ` Nathaniel Roach
2026-02-20 10:14 ` [PATCHv2 0/2] pci: fix msi_addr_mask on powerpc and sparc systems Vivian Wang
2026-02-20 13:15 ` John Paul Adrian Glaubitz
2026-02-27 16:44 ` Bjorn Helgaas
2026-03-03 4:29 ` Madhavan Srinivasan
2026-03-03 16:30 ` Bjorn Helgaas
2026-03-02 23:07 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260302230753.GA4034944@bhelgaas \
--to=helgaas@kernel.org \
--cc=andreas@gaisler.com \
--cc=chleroy@kernel.org \
--cc=davem@davemloft.net \
--cc=gaohan@iscas.ac.cn \
--cc=gjoyce@ibm.com \
--cc=glaubitz@physik.fu-berlin.de \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=namcao@linutronix.de \
--cc=nilay@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=nroach44@nroach44.id.au \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@kernel.org \
--cc=venkat88@linux.ibm.com \
--cc=wangruikang@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox