From: Bjorn Helgaas <helgaas@kernel.org>
To: Jim Quinlan <james.quinlan@broadcom.com>
Cc: linux-pci@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com,
Bjorn Helgaas <bhelgaas@google.com>,
open list <linux-kernel@vger.kernel.org>,
Hans Zhang <18255117159@163.com>,
Niklas Cassel <cassel@kernel.org>
Subject: Re: [PATCH v2 RESEND 1/1] PCI: pcie_bus_config can be set at build time
Date: Mon, 2 Mar 2026 18:03:37 -0600 [thread overview]
Message-ID: <20260303000337.GA4038046@bhelgaas> (raw)
In-Reply-To: <CA+-6iNzJM=C+Byb+wnmPYdJcYoTT7N-XwE3o2OpJzmcJrtOc8A@mail.gmail.com>
On Tue, Feb 24, 2026 at 04:10:17PM -0500, Jim Quinlan wrote:
> On Fri, Feb 20, 2026 at 5:11 PM Bjorn Helgaas <helgaas@kernel.org> wrote:
> > On Mon, Sep 28, 2020 at 03:46:51PM -0400, Jim Quinlan wrote:
> > > The Kconfig is modified so that the pcie_bus_config setting can be done at
> > > build time in the same manner as the CONFIG_PCIEASPM_XXXX choice. The
> > > pci_bus_config setting may still be overridden by the bootline param.
> > >
> > > Signed-off-by: Jim Quinlan <james.quinlan@broadcom.com>
> >
> > We merged this as b0e85c3c8554 ("PCI: Add Kconfig options for MPS/MRRS
> > strategy"), which appeared in v5.10.
> >
> > In retrospect, I think this might have been a mistake because it
> > forces a build-time configuration for something that may not be known
> > at build time and can be set via command-line parameter.
> ...
> > But I can't find any discussion about it. Did you have a use case
> > where command line parameters weren't usable?
>
> Yes. We have a Cable Modem (CM) customer who can update their Linux
> version but cannot update their boot loader or its default bootline.
> FWIW, they only want the option to set pcie_bus_config to
> PCIE_BUS_SAFE via the .config.
> ...
> It's a CM product which uses a particular Wifi chip. Recognizing this
> scenario would have the RC trying to grab the EP's vendor-id (and
> possibly more info), and that seems awkward at best.
This is actually kind of weird. I don't know why a particular device
would have any special MPS or MRRS requirements.
Do you have any more details about this? Does the WiFi chip actually
not *work* with other MPS settings? Or is this a performance thing
where other settings don't give acceptable performance?
I assume there's no hotplug in this setup, so we don't't have to worry
about adding new devices at runtime. Do you know if there's any
P2PDMA usage?
next prev parent reply other threads:[~2026-03-03 0:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 19:46 [PATCH v2 RESEND 0/1] PCI: pcie_bus_config can be set at build time Jim Quinlan
2020-09-28 19:46 ` [PATCH v2 RESEND 1/1] " Jim Quinlan
2020-09-29 21:31 ` Bjorn Helgaas
2020-09-30 20:57 ` Jim Quinlan
2026-02-20 22:11 ` Bjorn Helgaas
2026-02-24 21:10 ` Jim Quinlan
2026-02-24 23:05 ` Bjorn Helgaas
2026-02-27 23:42 ` Jim Quinlan
2026-02-25 13:23 ` Niklas Cassel
2026-02-27 23:52 ` Jim Quinlan
2026-03-03 0:03 ` Bjorn Helgaas [this message]
2026-03-05 21:36 ` Jim Quinlan
2026-03-05 21:38 ` Florian Fainelli
2026-03-26 21:04 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260303000337.GA4038046@bhelgaas \
--to=helgaas@kernel.org \
--cc=18255117159@163.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=james.quinlan@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox