Re: [PATCH v3 5/5] pci: mark pci_set_vga_state() as __must_check

[Bjorn Helgaas <helgaas@kernel.org>]

On Sun, Mar 08, 2026 at 02:35:38AM +0900, Simon Richter wrote:
> This function can return an error, usually on non-x86 or virtualized
> environments.
> 
> The only caller so far is __vga_tryget() in vgaarb.

Is there any reason for pci_set_vga_state() to be in pci.c while the
only caller is in vgaarb.c?  If not, we could move it there, make it
static, and drop it from include/linux/pci.h.

> Signed-off-by: Simon Richter <Simon.Richter@hogyros.de>
> ---
>  include/linux/pci.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/pci.h b/include/linux/pci.h
> index 1c270f1d5123..aa1451d402d1 100644
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -1720,8 +1720,8 @@ resource_size_t pcibios_window_alignment(struct pci_bus *bus,
>  #define PCI_VGA_STATE_CHANGE_BRIDGE (1 << 0)
>  #define PCI_VGA_STATE_CHANGE_DECODES (1 << 1)
>  
> -int pci_set_vga_state(struct pci_dev *pdev, bool decode,
> -		      unsigned int command_bits, u32 flags);
> +int __must_check pci_set_vga_state(struct pci_dev *pdev, bool decode,
> +				   unsigned int command_bits, u32 flags);
>  
>  /*
>   * Virtual interrupts allow for more interrupts to be allocated
> -- 
> 2.47.3
>