From: David Jeffery <djeffery@redhat.com>
To: linux-kernel@vger.kernel.org, driver-core@lists.linux.dev,
linux-pci@vger.kernel.org, linux-scsi@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>
Cc: "Tarun Sahu" <tarunsahu@google.com>,
"Pasha Tatashin" <tatashin@google.com>,
"Michał Cłapiński" <mclapinski@google.com>,
"Jordan Richards" <jordanrichards@google.com>,
"Ewan Milne" <emilne@redhat.com>,
"John Meneghini" <jmeneghi@redhat.com>,
"Lombardi, Maurizio" <mlombard@redhat.com>,
"David Jeffery" <djeffery@redhat.com>,
"Stuart Hayes" <stuart.w.hayes@gmail.com>,
"Laurence Oberman" <loberman@redhat.com>
Subject: [PATCH 5/5] scsi: enable async shutdown support
Date: Wed, 11 Mar 2026 13:12:09 -0400 [thread overview]
Message-ID: <20260311171209.9205-5-djeffery@redhat.com> (raw)
In-Reply-To: <20260311171209.9205-1-djeffery@redhat.com>
Like scsi's async suspend support, allow scsi devices to be shut down
asynchronously to improve system shutdown time.
Signed-off-by: David Jeffery <djeffery@redhat.com>
Signed-off-by: Stuart Hayes <stuart.w.hayes@gmail.com>
Tested-by: Laurence Oberman <loberman@redhat.com>
---
drivers/scsi/hosts.c | 3 +++
drivers/scsi/scsi_scan.c | 1 +
drivers/scsi/scsi_sysfs.c | 4 ++++
3 files changed, 8 insertions(+)
diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c
index e047747d4ecf..dfb38a82c0bf 100644
--- a/drivers/scsi/hosts.c
+++ b/drivers/scsi/hosts.c
@@ -273,6 +273,7 @@ int scsi_add_host_with_dma(struct Scsi_Host *shost, struct device *dev,
pm_runtime_set_active(&shost->shost_gendev);
pm_runtime_enable(&shost->shost_gendev);
device_enable_async_suspend(&shost->shost_gendev);
+ device_enable_async_shutdown(&shost->shost_gendev);
error = device_add(&shost->shost_gendev);
if (error)
@@ -282,6 +283,7 @@ int scsi_add_host_with_dma(struct Scsi_Host *shost, struct device *dev,
get_device(shost->shost_gendev.parent);
device_enable_async_suspend(&shost->shost_dev);
+ device_enable_async_shutdown(&shost->shost_dev);
get_device(&shost->shost_gendev);
error = device_add(&shost->shost_dev);
@@ -519,6 +521,7 @@ struct Scsi_Host *scsi_host_alloc(const struct scsi_host_template *sht, int priv
shost->shost_gendev.bus = &scsi_bus_type;
shost->shost_gendev.type = &scsi_host_type;
scsi_enable_async_suspend(&shost->shost_gendev);
+ device_enable_async_shutdown(&shost->shost_gendev);
device_initialize(&shost->shost_dev);
shost->shost_dev.parent = &shost->shost_gendev;
diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
index 60c06fa4ec32..c42b33e8ea8a 100644
--- a/drivers/scsi/scsi_scan.c
+++ b/drivers/scsi/scsi_scan.c
@@ -518,6 +518,7 @@ static struct scsi_target *scsi_alloc_target(struct device *parent,
dev->bus = &scsi_bus_type;
dev->type = &scsi_target_type;
scsi_enable_async_suspend(dev);
+ device_enable_async_shutdown(dev);
starget->id = id;
starget->channel = channel;
starget->can_queue = 0;
diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
index 6b8c5c05f294..c76ba17b206f 100644
--- a/drivers/scsi/scsi_sysfs.c
+++ b/drivers/scsi/scsi_sysfs.c
@@ -1370,6 +1370,7 @@ static int scsi_target_add(struct scsi_target *starget)
pm_runtime_set_active(&starget->dev);
pm_runtime_enable(&starget->dev);
device_enable_async_suspend(&starget->dev);
+ device_enable_async_shutdown(&starget->dev);
return 0;
}
@@ -1396,6 +1397,7 @@ int scsi_sysfs_add_sdev(struct scsi_device *sdev)
transport_configure_device(&starget->dev);
device_enable_async_suspend(&sdev->sdev_gendev);
+ device_enable_async_shutdown(&sdev->sdev_gendev);
scsi_autopm_get_target(starget);
pm_runtime_set_active(&sdev->sdev_gendev);
if (!sdev->rpm_autosuspend)
@@ -1415,6 +1417,7 @@ int scsi_sysfs_add_sdev(struct scsi_device *sdev)
}
device_enable_async_suspend(&sdev->sdev_dev);
+ device_enable_async_shutdown(&sdev->sdev_dev);
error = device_add(&sdev->sdev_dev);
if (error) {
sdev_printk(KERN_INFO, sdev,
@@ -1670,6 +1673,7 @@ void scsi_sysfs_device_initialize(struct scsi_device *sdev)
sdev->sdev_gendev.bus = &scsi_bus_type;
sdev->sdev_gendev.type = &scsi_dev_type;
scsi_enable_async_suspend(&sdev->sdev_gendev);
+ device_enable_async_shutdown(&sdev->sdev_gendev);
dev_set_name(&sdev->sdev_gendev, "%d:%d:%d:%llu",
sdev->host->host_no, sdev->channel, sdev->id, sdev->lun);
sdev->sdev_gendev.groups = hostt->sdev_groups;
--
2.53.0
next prev parent reply other threads:[~2026-03-11 17:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 17:12 [PATCH 1/5] driver core: do not always lock parent in shutdown David Jeffery
2026-03-11 17:12 ` [PATCH 2/5] driver core: separate function to shutdown one device David Jeffery
2026-03-11 18:00 ` Bart Van Assche
2026-03-11 21:37 ` Bjorn Helgaas
2026-03-11 21:42 ` Bart Van Assche
2026-03-12 13:39 ` David Jeffery
2026-03-12 1:49 ` kernel test robot
2026-03-12 5:10 ` kernel test robot
2026-03-11 17:12 ` [PATCH 3/5] driver core: async device shutdown infrastructure David Jeffery
2026-03-11 19:40 ` Randy Dunlap
2026-03-11 23:05 ` Bjorn Helgaas
2026-03-12 14:01 ` David Jeffery
2026-03-11 17:12 ` [PATCH 4/5] pci: enable async shutdown support David Jeffery
2026-03-11 23:08 ` Bjorn Helgaas
2026-03-12 13:46 ` David Jeffery
2026-03-12 5:09 ` Greg Kroah-Hartman
2026-03-12 13:54 ` David Jeffery
2026-03-11 17:12 ` David Jeffery [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-03-19 14:11 [PATCH v12 0/5] shut down devices asynchronously David Jeffery
2026-03-19 14:11 ` [PATCH 5/5] scsi: enable async shutdown support David Jeffery
2026-03-20 2:20 ` Martin K. Petersen
2026-04-07 15:35 [PATCH v13 0/5] shut down devices asynchronously David Jeffery
2026-04-07 15:35 ` [PATCH 5/5] scsi: enable async shutdown support David Jeffery
2026-04-07 16:34 ` John Garry
2026-04-08 14:16 ` David Jeffery
2026-04-08 15:53 ` John Garry
2026-04-08 19:35 ` David Jeffery
2026-04-09 12:17 ` John Garry
2026-04-09 20:36 ` David Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260311171209.9205-5-djeffery@redhat.com \
--to=djeffery@redhat.com \
--cc=dakr@kernel.org \
--cc=driver-core@lists.linux.dev \
--cc=emilne@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jmeneghi@redhat.com \
--cc=jordanrichards@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=loberman@redhat.com \
--cc=mclapinski@google.com \
--cc=mlombard@redhat.com \
--cc=rafael@kernel.org \
--cc=stuart.w.hayes@gmail.com \
--cc=tarunsahu@google.com \
--cc=tatashin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox