public inbox for linux-pci@vger.kernel.org
 help / color / mirror / Atom feed
From: Niklas Cassel <cassel@kernel.org>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Manikanta Maddireddy <mmaddireddy@nvidia.com>,
	Koichiro Den <den@valinux.co.jp>,
	Damien Le Moal <dlemoal@kernel.org>,
	Niklas Cassel <cassel@kernel.org>,
	linux-pci@vger.kernel.org
Subject: [PATCH v4 02/10] PCI: endpoint: Allow only_64bit on BAR_RESERVED
Date: Thu, 12 Mar 2026 14:02:30 +0100	[thread overview]
Message-ID: <20260312130229.2282001-14-cassel@kernel.org> (raw)
In-Reply-To: <20260312130229.2282001-12-cassel@kernel.org>

From: Manikanta Maddireddy <mmaddireddy@nvidia.com>

Remove the documentation that forbids setting only_64bit on a BAR of type
BAR_RESERVED.

When a reserved BAR is 64-bit by default, setting only_64bit is the most
accurate description. If we later add support to disable a reserved BAR
(e.g. disable_bar() for BARs that were never set via set_bar()), the
implementation will need to clear the adjacent BAR (upper 32 bits) as well;
having only_64bit set documents that requirement.

Signed-off-by: Manikanta Maddireddy <mmaddireddy@nvidia.com>
Signed-off-by: Niklas Cassel <cassel@kernel.org>
---
 include/linux/pci-epc.h | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/include/linux/pci-epc.h b/include/linux/pci-epc.h
index c981ea7d52c0..5c59f5606869 100644
--- a/include/linux/pci-epc.h
+++ b/include/linux/pci-epc.h
@@ -207,11 +207,6 @@ enum pci_epc_bar_type {
  * @only_64bit: if true, an EPF driver is not allowed to choose if this BAR
  *		should be configured as 32-bit or 64-bit, the EPF driver must
  *		configure this BAR as 64-bit.
- *
- *		only_64bit should not be set on a BAR of type BAR_RESERVED.
- *		(If BARx is a 64-bit BAR that an EPF driver is not allowed to
- *		touch, then both BARx and BARx+1 must be set to type
- *		BAR_RESERVED.)
  */
 struct pci_epc_bar_desc {
 	enum pci_epc_bar_type type;
-- 
2.53.0


  parent reply	other threads:[~2026-03-12 13:03 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-12 13:02 [PATCH v4 00/10] PCI: endpoint: Differentiate between disabled and reserved BARs Niklas Cassel
2026-03-12 13:02 ` [PATCH v4 01/10] PCI: endpoint: Do not mark the BAR succeeding a 64-bit BAR as BAR_RESERVED Niklas Cassel
2026-03-12 13:02 ` Niklas Cassel [this message]
2026-03-12 13:02 ` [PATCH v4 03/10] PCI: endpoint: Describe reserved subregions within BARs Niklas Cassel
2026-03-12 13:02 ` [PATCH v4 04/10] PCI: dw-rockchip: Describe RK3588 BAR4 DMA ctrl window Niklas Cassel
2026-03-12 13:02 ` [PATCH v4 05/10] PCI: endpoint: Introduce pci_epc_bar_type BAR_DISABLED Niklas Cassel
2026-03-12 13:02 ` [PATCH v4 06/10] PCI: dwc: Replace certain BAR_RESERVED with BAR_DISABLED in glue drivers Niklas Cassel
2026-03-12 13:02 ` [PATCH v4 07/10] PCI: dwc: Disable BARs in common code instead of in each glue driver Niklas Cassel
2026-03-12 13:02 ` [PATCH v4 08/10] PCI: endpoint: pci-epf-test: Advertise reserved BARs Niklas Cassel
2026-03-12 13:02 ` [PATCH v4 09/10] misc: pci_endpoint_test: Give reserved BARs a distinct error code Niklas Cassel
2026-03-15 16:36   ` Manivannan Sadhasivam
2026-03-12 13:02 ` [PATCH v4 10/10] selftests: pci_endpoint: Skip reserved BARs Niklas Cassel
2026-03-15 16:38 ` [PATCH v4 00/10] PCI: endpoint: Differentiate between disabled and " Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260312130229.2282001-14-cassel@kernel.org \
    --to=cassel@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=den@valinux.co.jp \
    --cc=dlemoal@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mmaddireddy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox