From: Bjorn Helgaas <helgaas@kernel.org>
To: Richard Cheng <icheng@nvidia.com>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, kristinc@nvidia.com,
newtonl@nvidia.com, kaihengf@nvidia.com, tdave@nvidia.com
Subject: Re: [PATCH] PCI: use pr_warn_once for ACS parameter parse failure
Date: Thu, 12 Mar 2026 16:52:00 -0500 [thread overview]
Message-ID: <20260312215200.GA1232914@bhelgaas> (raw)
In-Reply-To: <20260312115441.8168-1-icheng@nvidia.com>
On Thu, Mar 12, 2026 at 07:54:41PM +0800, Richard Cheng wrote:
> When the ACS command line parameter cannot be parsed, the kernel skips
> applying the requested ACS override. This indicates an invalid boot
> parameter and should not be logged at informational level.
>
> Use pr_warn_once() so the message is surfaced as a warning while still
> avoiding repeated log spam during device enumeration.
>
> Signed-off-by: Richard Cheng <icheng@nvidia.com>
> Acked-by: Tushar Dave <tdave@nvidia.com>
Applied to pci/misc for v7.1, thanks!
> ---
> drivers/pci/pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index 13dbb405dc31..4e3b051c0f5f 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -953,7 +953,7 @@ static void __pci_config_acs(struct pci_dev *dev, struct pci_acs *caps,
>
> ret = pci_dev_str_match(dev, p, &p);
> if (ret < 0) {
> - pr_info_once("PCI: Can't parse ACS command line parameter\n");
> + pr_warn_once("PCI: Can't parse ACS command line parameter\n");
> break;
> } else if (ret == 1) {
> /* Found a match */
> --
> 2.51.0
>
>
prev parent reply other threads:[~2026-03-12 21:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 11:54 [PATCH] PCI: use pr_warn_once for ACS parameter parse failure Richard Cheng
2026-03-12 21:52 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260312215200.GA1232914@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=icheng@nvidia.com \
--cc=kaihengf@nvidia.com \
--cc=kristinc@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=newtonl@nvidia.com \
--cc=tdave@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox