From: "Krzysztof Wilczyński" <kwilczynski@kernel.org>
To: lirongqing <lirongqing@baidu.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][v2] PCI: sysfs: Suppress FW_BUG warning when NUMA node already matches
Date: Tue, 17 Mar 2026 10:20:53 +0900 [thread overview]
Message-ID: <20260317012053.GA1575592@rocinante> (raw)
In-Reply-To: <20260317002803.2353-1-lirongqing@baidu.com>
Hello,
The patch is very nice, so much cleaner now.
> The numa_node sysfs interface allows users to manually override a PCI
> device's NUMA node assignment. Currently, every write triggers a
> FW_BUG warning and taints the kernel, even when writing the same value
> that is already set.
>
> Check if the requested node is already assigned to the device. If it
> matches, return success immediately without tainting the kernel or
> printing a warning.
Something for future reference:
- The [PATCH][v2] would be better as [PATCH v2], as per the usual format
- The "PCI: sysfs" prefix that we use more often is "PCI/sysfs"
No need to send v3 just to fix this, unless someone (like Bjorn) would ask.
Thank you!
Krzysztof
next prev parent reply other threads:[~2026-03-17 1:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 0:28 [PATCH][v2] PCI: sysfs: Suppress FW_BUG warning when NUMA node already matches lirongqing
2026-03-17 1:20 ` Krzysztof Wilczyński [this message]
2026-03-17 21:33 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260317012053.GA1575592@rocinante \
--to=kwilczynski@kernel.org \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lirongqing@baidu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox